Bug 148451 – [Win] Expose "Inverted Colors" option in WinLauncher

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Brent Fulgham]

WebKit supports an inverted color mode for Accessibility. This option is not accessible in WinLauncher, which makes experimenting with the feature difficult.

This patch adds a menu option to the "View" menu so that you can run WinLauncher with inverted colors.

[Brent Fulgham]

Created attachment 259899 [details]
Patch

[Said Abou-Hallawa]

Comment on attachment 259899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259899&action=review

> Tools/WinLauncher/Common.cpp:494
> +        case IDM_INVERT_COLORS:

WinProc() and ToggleMenuItem() checks for the same set of wmIds. Can't we make ToggleMenuItem() returns true if handles the wmId and false if it does not? The default case of switch (wmId) in WinProc can be like this:

        default:
            if (!ToggleMenuItem(hWnd, mId))
                return CallWindowProc(parentProc, hWnd, message, wParam, lParam);
        }

[Brent Fulgham]

Committed r188939: <http://trac.webkit.org/changeset/188939>

[Brent Fulgham]

(In reply to comment #2)
> Comment on attachment 259899 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259899&action=review
> 
> > Tools/WinLauncher/Common.cpp:494
> > +        case IDM_INVERT_COLORS:
> 
> WinProc() and ToggleMenuItem() checks for the same set of wmIds. Can't we
> make ToggleMenuItem() returns true if handles the wmId and false if it does
> not? The default case of switch (wmId) in WinProc can be like this:
> 
>         default:
>             if (!ToggleMenuItem(hWnd, mId))
>                 return CallWindowProc(parentProc, hWnd, message, wParam,
> lParam);
>         }

That's a great idea! I'll try to put a patch together for that.

Thanks!