Bug 148443

Summary: DFG::StrCat isn't really effectful
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-08-25 13:10:15 PDT
Currently clobberize thinks that it is, even though it isn't.
Attachments
the patch (13.56 KB, patch)
2015-08-27 14:19 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-27 14:19:40 PDT
Created attachment 260087 [details] the patch
WebKit Commit Bot
Comment 2 2015-08-27 14:22:28 PDT
Attachment 260087 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:168: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2015-08-27 16:54:41 PDT
Comment on attachment 260087 [details] the patch r=me
Filip Pizlo
Comment 4 2015-08-27 17:00:33 PDT
Landed in http://trac.webkit.org/changeset/189075
Note You need to log in before you can comment on or make changes to this bug.