| Summary: | Construct default winding string arguments in CanvasRenderingContext2D from ASCIILiteral objects | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, gyuyoung.kim | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2015-08-25 12:17:29 PDT
Created attachment 259870 [details]
Patch
Comment on attachment 259870 [details]
Patch
This is a slight optimization. Could optimize even more by overloading instead so we wouldn’t even have to allocate/destroy a StringImpl each time.
At least this case could be improved by generating better bindings code. There the string value is already tested to throw a type error if it doesn't equal either 'nonzero' or 'evenodd', so it would then just be a matter of passing an enum value to the implementation function. Committed r189248: <http://trac.webkit.org/changeset/189248> |