Bug 148428

Summary: Fix the all-in-one build with GCC
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ossy
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Csaba Osztrogonác 2015-08-25 05:54:06 PDT
The all-in-one build is broken with GCC (works fine with Clang) since Indexed DB is enabled:

../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:718:7: error: 'WebCore::ClearObjectStore' has a field 'WebCore::ClearObjectStore::<anonymous>' whose type uses the anonymous namespace [-Werror]
../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:718:7: error: 'WebCore::ClearObjectStore' has a base 'WebCore::{anonymous}::ExecutableWithDatabase' whose type uses the anonymous namespace [-Werror]

A possible workaround is removing InspectorIndexedDBAgent.cpp from 
Source/WebCore/inspector/InspectorAllInOne.cpp until we find the proper fix.
Comment 1 Csaba Osztrogonác 2015-09-21 04:54:40 PDT
Created attachment 261645 [details]
Patch
Comment 2 Darin Adler 2015-09-21 16:37:21 PDT
Comment on attachment 261645 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261645&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Fix the all-in-one build with GCC

How is this specific to EFL?
Comment 3 Csaba Osztrogonác 2015-09-22 03:04:18 PDT
(In reply to comment #2)
> Comment on attachment 261645 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=261645&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [EFL] Fix the all-in-one build with GCC
> 
> How is this specific to EFL?

Good point, I think nohow.
Comment 4 Csaba Osztrogonác 2015-09-22 03:06:30 PDT
Committed r190112: <http://trac.webkit.org/changeset/190112>