Bug 148427

Summary:

Improve ScriptExecutionContext::Task creation and usage

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review-

Description Zan Dobersek 2015-08-25 05:05:34 PDT

Improve ScriptExecutionContext::Task creation and usage

Comment 1 Zan Dobersek 2015-08-25 05:51:45 PDT

Created attachment 259839 [details]
Patch

Comment 2 WebKit Commit Bot 2015-08-25 05:54:09 PDT

Attachment 259839 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/ScriptExecutionContext.h:125:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:131:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:139:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:144:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/dom/ScriptExecutionContext.h:149:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/bindings/js/JSDOMGlobalObjectTask.cpp:83:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Zan Dobersek 2015-09-01 23:19:08 PDT

*** Bug 133541 has been marked as a duplicate of this bug. ***

Comment 4 Michael Catanzaro 2015-12-31 14:40:19 PST

Comment on attachment 259839 [details]
Patch

It doesn't work on Windows, e.g.

c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(205): error C2668: 'WebCore::ScriptExecutionContext::Task::Task': ambiguous call to overloaded function (compiling source file ..\loader\MixedContentChecker.cpp) [C:\cygwin\home\buildbot\WebKit\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
  c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(131): note: could be 'WebCore::ScriptExecutionContext::Task::Task(std::function<void (void)> &&)' (compiling source file ..\loader\MixedContentChecker.cpp)
  c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(125): note: or       'WebCore::ScriptExecutionContext::Task::Task(std::function<void (WebCore::ScriptExecutionContext &)> &&)' (compiling source file ..\loader\MixedContentChecker.cpp)
  c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(144): note: or       'WebCore::ScriptExecutionContext::Task::Task<WebCore::ScriptExecutionContext::AddConsoleMessageTask::<lambda_98457798a604deaf84bb96f062be9ef1>>(T &&,void *)'
          with
          [
              T=WebCore::ScriptExecutionContext::AddConsoleMessageTask::<lambda_98457798a604deaf84bb96f062be9ef1>
          ] (compiling source file ..\loader\MixedContentChecker.cpp)
  c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(138): note: or       'WebCore::ScriptExecutionContext::Task::Task<WebCore::ScriptExecutionContext::AddConsoleMessageTask::<lambda_98457798a604deaf84bb96f062be9ef1>>(T &&,void *)'
          with
          [
              T=WebCore::ScriptExecutionContext::AddConsoleMessageTask::<lambda_98457798a604deaf84bb96f062be9ef1>
          ] (compiling source file ..\loader\MixedContentChecker.cpp)
  c:\cygwin\home\buildbot\webkit\source\webcore\dom\ScriptExecutionContext.h(205): note: while trying to match the argument list '(WebCore::ScriptExecutionContext::AddConsoleMessageTask::<lambda_98457798a604deaf84bb96f062be9ef1>)' (compiling source file ..\loader\MixedContentChecker.cpp)