Bug 148424

Summary:

Fix the !ENABLE(VIDEO) build after r188693

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, thorton

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

148195

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2015-08-25 02:48:49 PDT

http://trac.webkit.org/changeset/188693 broke the !ENABLE(VIDEO) build,
because ChromeClient::imageOrMediaDocumentSizeChanged() is defined
inside ENABLE(VIDEO) guard, but is overriden unconfitionally:

../../Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:328:18: error: 'virtual void WebKit::WebChromeClient::imageOrMediaDocumentSizeChanged(const WebCore::IntSize&)' marked override, but does not override

Comment 1 Csaba Osztrogonác 2015-08-25 02:52:19 PDT

Created attachment 259834 [details]
Patch

Comment 2 WebKit Commit Bot 2015-08-25 11:13:20 PDT

Comment on attachment 259834 [details]
Patch

Clearing flags on attachment: 259834

Committed r188923: <http://trac.webkit.org/changeset/188923>

Comment 3 WebKit Commit Bot 2015-08-25 11:13:24 PDT

All reviewed patches have been landed.  Closing bug.