Bug 148422 – Subpixel positioned iframe's repaint area calculation problem.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Jinyoung Hur]

Created attachment 259828 [details]
screen capture of bug

I've been digging a plugin rendering problem of Win port, which is not-rendering the bottom or right edge of flash contents in some situation.
After some investigation, I got to suspect the subpixel positioning of widgets and found a related layout test, hidpi-content-inside-iframe-leaves-trails.html.
I modified this test little bit to reflect my circumstances(iframe left = 0.5, foo div left = 0.5), and it shows a problematic result, the repaint area is not covering the whole area of the changed element.

I've tested and seen this on Safari8, Win and WinCairo port's WinLauncher.

Can anybody look into this?

[Jinyoung Hur]

Created attachment 259829 [details]
simple content

[alan]

Created attachment 259987 [details]
Patch

[Build Bot]

Comment on attachment 259987 [details]
Patch

Attachment 259987 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/110716

New failing tests:
fast/repaint/hidpi-content-inside-iframe-leaves-trails.html

[Build Bot]

Created attachment 259988 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[alan]

Created attachment 259989 [details]
Patch

[Build Bot]

Comment on attachment 259989 [details]
Patch

Attachment 259989 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/110844

New failing tests:
fast/repaint/hidpi-content-inside-iframe-leaves-trails.html

[Build Bot]

Created attachment 259993 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 259989 [details]
Patch

Attachment 259989 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/110847

New failing tests:
fast/repaint/hidpi-content-inside-iframe-leaves-trails.html

[Build Bot]

Created attachment 259994 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[alan]

Created attachment 260018 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 260018 [details]
Patch

Rejecting attachment 260018 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260018, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   e3ca448..837354a  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 189021 = e3ca4483d588f09c02f6d27ea59adb03257957b9
r189022 = 837354a887b5501d5be8dc51b8b4c4e47c9c97e6
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/112904

[alan]

Created attachment 260055 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 260055 [details]
Patch

Clearing flags on attachment: 260055

Committed r189026: <http://trac.webkit.org/changeset/189026>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jinyoung Hur]

Thanks for a fast patch.
It's working!

[alan]

(In reply to comment #15)
> Thanks for a fast patch.
> It's working!
Great! Thanks for reporting it!