Bug 148412

Summary: Web Inspector: Rendering Frames pie chart should use the needsLayout/updateLayout idiom
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Patch] Proposed Fix
none
[Patch] Proposed Fix none

Matt Baker
Reported 2015-08-24 19:07:46 PDT
* SUMMARY Rendering Frames pie chart should use the needsLayout/updateLayout idiom. The chart should also allow existing values to be updated, so we don't have to rebuild the legend every time a frame is added to the timeline.
Attachments
[Patch] Proposed Fix (12.54 KB, patch)
2015-08-24 19:24 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (12.52 KB, patch)
2015-08-25 10:24 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-24 19:08:20 PDT
<rdar://problem/22413304>
Matt Baker
Comment 2 2015-08-24 19:24:05 PDT
Created attachment 259807 [details] [Patch] Proposed Fix
Timothy Hatcher
Comment 3 2015-08-25 10:06:34 PDT
Comment on attachment 259807 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259807&action=review > Source/WebInspectorUI/UserInterface/Views/ChartDetailsSectionRow.js:205 > + else > + return item.value; No else.
Matt Baker
Comment 4 2015-08-25 10:24:12 PDT
Created attachment 259856 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 5 2015-08-25 10:55:22 PDT
Comment on attachment 259856 [details] [Patch] Proposed Fix Clearing flags on attachment: 259856 Committed r188916: <http://trac.webkit.org/changeset/188916>
WebKit Commit Bot
Comment 6 2015-08-25 10:55:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.