Bug 148402

Summary:

Long press gesture recognizer should adjust delay based on other recognizers

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, dbates

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2015-08-24 15:34:16 PDT

Long press gesture recognizer should adjust delay based on other recognizers

rdar://problem/22278723

Comment 1 Beth Dakin 2015-08-24 15:36:29 PDT

Created attachment 259784 [details]
Patch

Comment 2 Tim Horton 2015-08-24 22:59:53 PDT

Comment on attachment 259784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:73
> +#import <WebKitAdditions/WKContentViewInteraction.mm>

You need to wrap this in a __has_include.

Comment 3 Tim Horton 2015-08-24 23:00:31 PDT

Comment on attachment 259784 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:346
> +    if ([_longPressGestureRecognizer respondsToSelector:@selector(_setAdjustsDelayBasedOnOtherRecognizers:)])

And this too (or, forward declare _setAdjustsDelayBasedOnOtherRecognizers).

Comment 4 Beth Dakin 2015-08-25 11:19:43 PDT

Thanks Tim! http://trac.webkit.org/changeset/188924