Bug 148402

Summary:

Long press gesture recognizer should adjust delay based on other recognizers

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, dbates

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Beth Dakin

Reported 2015-08-24 15:34:16 PDT

Long press gesture recognizer should adjust delay based on other recognizers rdar://problem/22278723

Attachments
Patch (1.93 KB, patch) 2015-08-24 15:36 PDT, Beth Dakin	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Beth Dakin

Comment 1 2015-08-24 15:36:29 PDT

Created attachment 259784 [details] Patch

Tim Horton

Comment 2 2015-08-24 22:59:53 PDT

Comment on attachment 259784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:73 > +#import <WebKitAdditions/WKContentViewInteraction.mm> You need to wrap this in a __has_include.

Tim Horton

Comment 3 2015-08-24 23:00:31 PDT

Comment on attachment 259784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259784&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:346 > + if ([_longPressGestureRecognizer respondsToSelector:@selector(_setAdjustsDelayBasedOnOtherRecognizers:)]) And this too (or, forward declare _setAdjustsDelayBasedOnOtherRecognizers).

Beth Dakin

Comment 4 2015-08-25 11:19:43 PDT

Thanks Tim! http://trac.webkit.org/changeset/188924

Note You need to log in before you can comment on or make changes to this bug.