Bug 148397

Summary: DFG::FixupPhase should use the lambda form of m_graph.doToChildren() rather than the old macro
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145204    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-08-24 14:38:07 PDT
Patch forthcoming.
Attachments
the patch (14.26 KB, patch)
2015-08-24 14:40 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-24 14:40:12 PDT
Created attachment 259777 [details] the patch
Geoffrey Garen
Comment 2 2015-08-24 14:41:52 PDT
Comment on attachment 259777 [details] the patch r=me
WebKit Commit Bot
Comment 3 2015-08-24 14:43:28 PDT
Attachment 259777 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2123: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:2176: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2015-08-24 14:45:13 PDT
Landed in http://trac.webkit.org/changeset/188886
Note You need to log in before you can comment on or make changes to this bug.