Bug 148394

Summary: Add support for setting JSC options from a file.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the fix.
none
fix 2: use ASCIICType this time. saam: review+

Mark Lam
Reported 2015-08-24 14:26:57 PDT
This is needed for environments where the JSC executable does not have access to environmental variables. This is only needed for debugging, and is currently guarded under a #define USE_OPTIONS_FILE in Options.cpp, and is disabled by default.
Attachments
the fix. (4.09 KB, patch)
2015-08-24 14:36 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
fix 2: use ASCIICType this time. (4.14 KB, patch)
2015-08-24 14:45 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-08-24 14:36:06 PDT
Created attachment 259772 [details] the fix.
WebKit Commit Bot
Comment 2 2015-08-24 14:38:32 PDT
Attachment 259772 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.cpp:443: Use equivelent function in <wtf/ASCIICType.h> instead of the isspace() function. [runtime/ctype_function] [4] ERROR: Source/JavaScriptCore/runtime/Options.cpp:469: Use equivelent function in <wtf/ASCIICType.h> instead of the isspace() function. [runtime/ctype_function] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2015-08-24 14:45:49 PDT
Created attachment 259780 [details] fix 2: use ASCIICType this time.
Saam Barati
Comment 4 2015-08-24 14:48:17 PDT
Comment on attachment 259780 [details] fix 2: use ASCIICType this time. r=me
Mark Lam
Comment 5 2015-08-24 14:52:40 PDT
Thanks. Landed in r188887: <http://trac.webkit.org/r188887>.
Note You need to log in before you can comment on or make changes to this bug.