| Summary: | Isolate Source directories in CMake build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | WebKit Misc. | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ossy | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 148111 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2015-08-24 12:36:05 PDT
Created attachment 259765 [details]
Patch
Created attachment 259766 [details]
Patch
Comment on attachment 259766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259766&action=review > ChangeLog:10 > + * CMakeLists.txt: > + * Source/cmake/WebKitCommon.cmake: > + Move package finding to WebKitCommon. How is it related to this bug? (In reply to comment #3) > Comment on attachment 259766 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259766&action=review > > > ChangeLog:10 > > + * CMakeLists.txt: > > + * Source/cmake/WebKitCommon.cmake: > > + Move package finding to WebKitCommon. > > How is it related to this bug? A directory must be able to be built with only what is in it and Source/cmake in order to switch the Windows build to CMake. Right now, it fails without this because finding things like Bison is done in ./CMakeLists.txt, which is not there when we are only building WTF, for example. Comment on attachment 259766 [details]
Patch
r=me
|