Bug 148389

Summary: Isolate Source directories in CMake build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebKit Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 148111    
Attachments:
Description Flags
Patch
none
Patch bfulgham: review+

Alex Christensen
Reported 2015-08-24 12:36:05 PDT
Internal Windows build needs directories completely separated.
Attachments
Patch (15.54 KB, patch)
2015-08-24 12:48 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (15.66 KB, patch)
2015-08-24 12:50 PDT, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-08-24 12:48:25 PDT
Created attachment 259765 [details] Patch
Alex Christensen
Comment 2 2015-08-24 12:50:10 PDT
Created attachment 259766 [details] Patch
Csaba Osztrogonác
Comment 3 2015-08-25 03:19:01 PDT
Comment on attachment 259766 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259766&action=review > ChangeLog:10 > + * CMakeLists.txt: > + * Source/cmake/WebKitCommon.cmake: > + Move package finding to WebKitCommon. How is it related to this bug?
Alex Christensen
Comment 4 2015-08-25 10:21:49 PDT
(In reply to comment #3) > Comment on attachment 259766 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259766&action=review > > > ChangeLog:10 > > + * CMakeLists.txt: > > + * Source/cmake/WebKitCommon.cmake: > > + Move package finding to WebKitCommon. > > How is it related to this bug? A directory must be able to be built with only what is in it and Source/cmake in order to switch the Windows build to CMake. Right now, it fails without this because finding things like Bison is done in ./CMakeLists.txt, which is not there when we are only building WTF, for example.
Brent Fulgham
Comment 5 2015-08-27 14:30:33 PDT
Comment on attachment 259766 [details] Patch r=me
Alex Christensen
Comment 6 2015-08-27 14:37:31 PDT
http://trac.webkit.org/changeset/189056
Note You need to log in before you can comment on or make changes to this bug.