Bug 148364

Summary:

Web Inspector: Drop webkit prefixes from animation, keyframes and transform

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Timothy Hatcher 2015-08-22 19:08:01 PDT

We could have dropped these a while ago.

Comment 1 Radar WebKit Bug Importer 2015-08-22 19:08:20 PDT

<rdar://problem/22393110>

Comment 2 Timothy Hatcher 2015-08-22 19:10:58 PDT

Created attachment 259727 [details]
Patch

Comment 3 WebKit Commit Bot 2015-08-23 09:31:29 PDT

Comment on attachment 259727 [details]
Patch

Clearing flags on attachment: 259727

Committed r188837: <http://trac.webkit.org/changeset/188837>

Comment 4 WebKit Commit Bot 2015-08-23 09:31:33 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2015-08-24 11:27:57 PDT

Comment on attachment 259727 [details]
Patch

There are a number of listeners for "webkitAnimationEnd". Do these also need to change to "animationEnd"?

    Views/DashboardContainerView.js
    193:            dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded);
    200:            dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded);
    226:            dashboardView.element.removeEventListener("webkitAnimationEnd", animationEnded);
    237:            dashboardView.element.addEventListener("webkitAnimationEnd", animationEnded);

    Views/DefaultDashboardView.js
    167:                container.removeEventListener("webkitAnimationEnd", animationEnded);
    177:            container.addEventListener("webkitAnimationEnd", animationEnded);

    Views/DOMTreeElement.js
    102:        this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));

    Views/TextEditor.js
    963:        this._bouncyHighlightElement.addEventListener("webkitAnimationEnd", animationEnded.bind(this));

Comment 6 Timothy Hatcher 2015-08-24 11:59:07 PDT

Good catch. Fixed in bug 148385.