Bug 148331

Summary: DFG::PutStackSinkingPhase doesn't need to emit KillStack nodes
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145204    
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-08-21 14:35:51 PDT
PutStackSinkingPhase currently emits KillStack nodes when it sinks a PutStack. This isn't necessary because KillStack is only interesting for OSR exit, and PutStack nodes that are relevant to OSR will already be preceded by a KillStack/MovHint pair.
Attachments
the patch (2.04 KB, patch)
2015-08-21 14:37 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-21 14:37:43 PDT
Created attachment 259660 [details] the patch
Geoffrey Garen
Comment 2 2015-08-21 14:39:25 PDT
Comment on attachment 259660 [details] the patch r=me
Filip Pizlo
Comment 3 2015-08-21 14:44:46 PDT
Landed in http://trac.webkit.org/changeset/188776
Note You need to log in before you can comment on or make changes to this bug.