Bug 148327

Summary: Deprecate the old school callOnMainThread/cancelCallOnMainThread functions
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2015-08-21 13:51:55 PDT
Deprecate the old school callOnMainThread/cancelCallOnMainThread functions
Attachments
Patch (10.99 KB, patch)
2015-08-21 13:58 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (11.02 KB, patch)
2015-08-21 14:03 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-08-21 13:58:09 PDT
Created attachment 259652 [details] Patch
WebKit Commit Bot
Comment 2 2015-08-21 14:01:01 PDT
Attachment 259652 [details] did not pass style-queue: ERROR: Source/WTF/wtf/MainThread.cpp:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:123: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:147: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-08-21 14:03:58 PDT
Created attachment 259653 [details] Patch
WebKit Commit Bot
Comment 4 2015-08-21 14:05:57 PDT
Attachment 259653 [details] did not pass style-queue: ERROR: Source/WTF/wtf/MainThread.cpp:50: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:52: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:123: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/MainThread.cpp:147: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2015-08-21 15:06:34 PDT
Committed r188788: <http://trac.webkit.org/changeset/188788>
Darin Adler
Comment 6 2015-08-21 15:30:52 PDT
Comment on attachment 259653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259653&action=review > Source/WTF/wtf/MainThread.cpp:123 > + std::function<void ()> function; I think this should be declared inside the while loop. > Source/WTF/wtf/MainThread.h:97 > +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1090 > +WTF_EXPORT_PRIVATE void callOnMainThread(MainThreadFunction*, void* context); > +WTF_EXPORT_PRIVATE void cancelCallOnMainThread(MainThreadFunction*, void* context); > +#endif I think the MainThreadFunction typedef should also be inside the #if. Or we can write void (*)(void*) instead of using a named type.
Note You need to log in before you can comment on or make changes to this bug.