Summary: | Improve how UI events are dispatched by WebKitTestRunner | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | Tools / Tests | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, bdakin, bfulgham, dbates, sam, thorton, wenson_hsieh | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 148155, 148470 | ||||||
Bug Blocks: | 148709 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2015-08-21 13:27:47 PDT
Created attachment 259655 [details]
proposed patch
Comment on attachment 259655 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=259655&action=review > Source/WebKit2/UIProcess/API/APIProcessPoolConfiguration.h:91 > + void allowFullySynchronousModeForTesting() { m_fullySynchronousModeIsAllowedForTesting = true; } This should be a getter/setter pair. > Source/WebKit2/UIProcess/API/C/WKContextConfigurationRef.h:58 > +WK_EXPORT void WKContextConfigurationAllowFullySynchronousModeForTesting(WKContextConfigurationRef configuration); Please add a getter/setter for this to match all the other WKContextConfiguration functions. Committed <https://trac.webkit.org/r188793>. Follow-up scrolling test tweak in r188827. It was flaky on some machines, randomly not scrolling where it should have, so I nudged some distances. Let's see if it helps. (In reply to comment #3) > Committed <https://trac.webkit.org/r188793>. Following this change, the tests fast/events/wheelevent-{basic, mousewheel-interaction}.html began to timeout in iOS Simulator WebKit Test Runner. See bug #148709. |