Bug 148313

Summary:

AX: Fix accessibility/mac/search-with-frames.html test

Product:

WebKit

Reporter:

Nan Wang <n_wang>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	none
patch	none
patch	none

Description Nan Wang 2015-08-21 10:40:56 PDT

The test is marked Pass/Failure in TestExpectation file.

Comment 1 Nan Wang 2015-08-21 10:46:42 PDT

Created attachment 259632 [details]
patch

Comment 2 WebKit Commit Bot 2015-08-21 13:00:59 PDT

Comment on attachment 259632 [details]
patch

Clearing flags on attachment: 259632

Committed r188770: <http://trac.webkit.org/changeset/188770>

Comment 3 WebKit Commit Bot 2015-08-21 13:01:02 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Alexey Proskuryakov 2015-08-21 16:43:48 PDT

The test is still failing, although not as frequently as before. It should be marked as flaky again.

Comment 5 Tim Horton 2015-08-21 16:47:05 PDT

I remarked it in http://trac.webkit.org/changeset/188800

Comment 6 Nan Wang 2015-08-21 16:48:02 PDT

(In reply to comment #4)
> The test is still failing, although not as frequently as before. It should
> be marked as flaky again.

I'll investigate.

Comment 7 Nan Wang 2015-08-24 17:19:16 PDT

Created attachment 259795 [details]
patch

Comment 8 chris fleizach 2015-08-24 17:53:21 PDT

Comment on attachment 259795 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259795&action=review

> LayoutTests/accessibility/mac/search-with-frames.html:42
> +              if(ifrm.name == "frame1a")

need a space after if and before (

i would also rename ifrm -> "iframe" just for clarity

> LayoutTests/accessibility/mac/search-with-frames.html:44
> +              else if(ifrm.name == "frame2a")

ditto about spacing

> LayoutTests/accessibility/mac/search-with-frames.html:49
> +              // call runTest() when all frames have been loaded

make this a full sentence

"Call runTest... have been loaded."

Comment 9 Nan Wang 2015-08-24 17:59:03 PDT

Created attachment 259799 [details]
patch

Comment 10 WebKit Commit Bot 2015-08-24 18:48:32 PDT

Comment on attachment 259799 [details]
patch

Clearing flags on attachment: 259799

Committed r188901: <http://trac.webkit.org/changeset/188901>

Comment 11 WebKit Commit Bot 2015-08-24 18:48:37 PDT

All reviewed patches have been landed.  Closing bug.