Bug 148313

Summary: AX: Fix accessibility/mac/search-with-frames.html test
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

Nan Wang
Reported 2015-08-21 10:40:56 PDT
The test is marked Pass/Failure in TestExpectation file.
Attachments
patch (4.63 KB, patch)
2015-08-21 10:46 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (3.20 KB, patch)
2015-08-24 17:19 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (3.79 KB, patch)
2015-08-24 17:59 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nan Wang
Comment 1 2015-08-21 10:46:42 PDT
Created attachment 259632 [details] patch
WebKit Commit Bot
Comment 2 2015-08-21 13:00:59 PDT
Comment on attachment 259632 [details] patch Clearing flags on attachment: 259632 Committed r188770: <http://trac.webkit.org/changeset/188770>
WebKit Commit Bot
Comment 3 2015-08-21 13:01:02 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2015-08-21 16:43:48 PDT
The test is still failing, although not as frequently as before. It should be marked as flaky again.
Tim Horton
Comment 5 2015-08-21 16:47:05 PDT
I remarked it in http://trac.webkit.org/changeset/188800
Nan Wang
Comment 6 2015-08-21 16:48:02 PDT
(In reply to comment #4) > The test is still failing, although not as frequently as before. It should > be marked as flaky again. I'll investigate.
Nan Wang
Comment 7 2015-08-24 17:19:16 PDT
Created attachment 259795 [details] patch
chris fleizach
Comment 8 2015-08-24 17:53:21 PDT
Comment on attachment 259795 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=259795&action=review > LayoutTests/accessibility/mac/search-with-frames.html:42 > + if(ifrm.name == "frame1a") need a space after if and before ( i would also rename ifrm -> "iframe" just for clarity > LayoutTests/accessibility/mac/search-with-frames.html:44 > + else if(ifrm.name == "frame2a") ditto about spacing > LayoutTests/accessibility/mac/search-with-frames.html:49 > + // call runTest() when all frames have been loaded make this a full sentence "Call runTest... have been loaded."
Nan Wang
Comment 9 2015-08-24 17:59:03 PDT
Created attachment 259799 [details] patch
WebKit Commit Bot
Comment 10 2015-08-24 18:48:32 PDT
Comment on attachment 259799 [details] patch Clearing flags on attachment: 259799 Committed r188901: <http://trac.webkit.org/changeset/188901>
WebKit Commit Bot
Comment 11 2015-08-24 18:48:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.