Summary: | AX: Tables with anonymous rows can return NULL from cellForColumnAndRow (breaks VoiceOver navigation) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Doug Russell <d_russell> | ||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Doug Russell
2015-08-21 00:15:20 PDT
Created attachment 259589 [details]
Patch
Comment on attachment 259589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259589&action=review > Source/WebCore/ChangeLog:9 > + tableâs internal row list. However, when calculating the row range for a cell, some weird unicode apostrophe here > LayoutTests/ChangeLog:9 > + tableâs internal row list. However, when calculating the row range for a cell, ditto > LayoutTests/accessibility/aria-table-content.html:27 > + shouldBe("cell00.role", "'AXRole: AXCell'"); can we also add verification that this is the right cell shouldBeTrue("cell00.isEqual(table.rowAtIndex(0).childAtIndex(0))"); shouldBeTrue("cell01.isEqual(table.rowAtIndex(1).childAtIndex(0))"); Created attachment 259633 [details]
Patch
Comment on attachment 259633 [details] Patch Clearing flags on attachment: 259633 Committed r188769: <http://trac.webkit.org/changeset/188769> All reviewed patches have been landed. Closing bug. Looks like this broke a test on Windows: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Faria-table-content.html It looks like Windows doesn't support this method (cellForColumnAndRow) So we should skip this test on Win (In reply to comment #9) > It looks like Windows doesn't support this method (cellForColumnAndRow) > So we should skip this test on Win Skip patch uploaded in https://bugs.webkit.org/show_bug.cgi?id=148354 |