Bug 148293

Summary:

AX: Tables with anonymous rows can return NULL from cellForColumnAndRow (breaks VoiceOver navigation)

Product:

WebKit

Reporter:

Doug Russell <d_russell>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Doug Russell

Reported 2015-08-21 00:15:20 PDT

An aria table with CSS that causes a row to be anonymous can result in incorrect indexing leading to incorrect NULL values from cellForColumnAndRow

Attachments
Patch (7.70 KB, patch) 2015-08-21 00:17 PDT, Doug Russell	no flags	Details Formatted Diff Diff
Patch (7.97 KB, patch) 2015-08-21 11:11 PDT, Doug Russell	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-08-21 00:15:55 PDT

<rdar://problem/22375795>

Doug Russell

Comment 2 2015-08-21 00:17:59 PDT

Created attachment 259589 [details] Patch

James Craig

Comment 3 2015-08-21 01:31:31 PDT

<rdar://problem/22354983>

chris fleizach

Comment 4 2015-08-21 09:33:17 PDT

Comment on attachment 259589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259589&action=review > Source/WebCore/ChangeLog:9 > + tableâs internal row list. However, when calculating the row range for a cell, some weird unicode apostrophe here > LayoutTests/ChangeLog:9 > + tableâs internal row list. However, when calculating the row range for a cell, ditto > LayoutTests/accessibility/aria-table-content.html:27 > + shouldBe("cell00.role", "'AXRole: AXCell'"); can we also add verification that this is the right cell shouldBeTrue("cell00.isEqual(table.rowAtIndex(0).childAtIndex(0))"); shouldBeTrue("cell01.isEqual(table.rowAtIndex(1).childAtIndex(0))");

Doug Russell

Comment 5 2015-08-21 11:11:39 PDT

Created attachment 259633 [details] Patch

WebKit Commit Bot

Comment 6 2015-08-21 12:56:04 PDT

Comment on attachment 259633 [details] Patch Clearing flags on attachment: 259633 Committed r188769: <http://trac.webkit.org/changeset/188769>

WebKit Commit Bot

Comment 7 2015-08-21 12:56:08 PDT

All reviewed patches have been landed. Closing bug.

Tim Horton

Comment 8 2015-08-21 16:48:22 PDT

Looks like this broke a test on Windows: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Faria-table-content.html

chris fleizach

Comment 9 2015-08-21 16:50:56 PDT

It looks like Windows doesn't support this method (cellForColumnAndRow) So we should skip this test on Win

Doug Russell

Comment 10 2015-08-21 21:25:13 PDT

(In reply to comment #9) > It looks like Windows doesn't support this method (cellForColumnAndRow) > So we should skip this test on Win Skip patch uploaded in https://bugs.webkit.org/show_bug.cgi?id=148354

Note You need to log in before you can comment on or make changes to this bug.