Bug 148290

Summary: Drop NodeListBase class
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147980
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2015-08-20 22:02:03 PDT
Drop NodeListBase class and have HTMLCollection subclass NodeList directly. There is no reason we need another base class.
Attachments
Patch (11.30 KB, patch)
2015-08-20 22:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-08-20 22:05:08 PDT
Created attachment 259584 [details] Patch
Ryosuke Niwa
Comment 2 2015-08-21 00:41:55 PDT
Comment on attachment 259584 [details] Patch Funny, I've done exactly this in the past until Antti refactored it.
WebKit Commit Bot
Comment 3 2015-08-21 01:28:18 PDT
Comment on attachment 259584 [details] Patch Clearing flags on attachment: 259584 Committed r188753: <http://trac.webkit.org/changeset/188753>
WebKit Commit Bot
Comment 4 2015-08-21 01:28:22 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 5 2015-08-21 02:51:55 PDT
Comment on attachment 259584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259584&action=review > Source/WebCore/html/HTMLCollection.h:62 > -class HTMLCollection : public NodeListBase, public ScriptWrappable { > +// HTMLCollection subclasses NodeList to maintain legacy ObjC API compatibility. > +class HTMLCollection : public NodeList { It is somewhat confusing that HTMLCollection is now a subclass of NodeList in C++ but not in IDL. The pure virtual base might have been a better way to deal with the the legacy issue mentioned in the comment.
Antti Koivisto
Comment 6 2015-08-21 02:54:58 PDT
NodeListBase was a bad name though, something like LegacyObjCAPICollection would have been more informative.
Note You need to log in before you can comment on or make changes to this bug.