Bug 148289

Summary: Media Session: let UI clients change the volume of the focused media element
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, mrajca, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch thorton: review+

Matt Rajca
Reported 2015-08-20 21:42:13 PDT
UI clients should be able to adjust the volume of the focused media element.
Attachments
Patch (9.53 KB, patch)
2015-08-20 21:46 PDT, Matt Rajca 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-20 21:42:45 PDT
<rdar://problem/22374771>
Matt Rajca
Comment 2 2015-08-20 21:46:06 PDT
Created attachment 259583 [details] Patch
Eric Carlson
Comment 3 2015-08-21 09:12:06 PDT
Comment on attachment 259583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259583&action=review Looks good to me. > Source/WebCore/page/Page.cpp:1232 > + ExceptionCode code; > + element->setVolume(volume, code); Nit: you should use ASSERT_NO_EXCEPTION here.
Matt Rajca
Comment 4 2015-08-21 17:03:12 PDT
Committed r188775: <http://trac.webkit.org/changeset/188775>
Matt Rajca
Comment 5 2015-08-21 17:52:52 PDT
(In reply to comment #3) > Comment on attachment 259583 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259583&action=review > > Looks good to me. > > > Source/WebCore/page/Page.cpp:1232 > > + ExceptionCode code; > > + element->setVolume(volume, code); > > Nit: you should use ASSERT_NO_EXCEPTION here. Done.
Note You need to log in before you can comment on or make changes to this bug.