Bug 148289

Summary:

Media Session: let UI clients change the volume of the focused media element

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

conrad_shultz, eric.carlson, mrajca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	thorton: review+

Description Matt Rajca 2015-08-20 21:42:13 PDT

UI clients should be able to adjust the volume of the focused media element.

Comment 1 Radar WebKit Bug Importer 2015-08-20 21:42:45 PDT

<rdar://problem/22374771>

Comment 2 Matt Rajca 2015-08-20 21:46:06 PDT

Created attachment 259583 [details]
Patch

Comment 3 Eric Carlson 2015-08-21 09:12:06 PDT

Comment on attachment 259583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259583&action=review

Looks good to me.

> Source/WebCore/page/Page.cpp:1232
> +        ExceptionCode code;
> +        element->setVolume(volume, code);

Nit: you should use ASSERT_NO_EXCEPTION here.

Comment 4 Matt Rajca 2015-08-21 17:03:12 PDT

Committed r188775: <http://trac.webkit.org/changeset/188775>

Comment 5 Matt Rajca 2015-08-21 17:52:52 PDT

(In reply to comment #3)
> Comment on attachment 259583 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259583&action=review
> 
> Looks good to me.
> 
> > Source/WebCore/page/Page.cpp:1232
> > +        ExceptionCode code;
> > +        element->setVolume(volume, code);
> 
> Nit: you should use ASSERT_NO_EXCEPTION here.

Done.