| Summary: | Have more getElementsBy*() methods return a Ref<> | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, kangil.han, koivisto, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2015-08-20 21:23:46 PDT
Created attachment 259582 [details]
Patch
Comment on attachment 259582 [details] Patch Rejecting attachment 259582 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 259582, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed at 1 with fuzz 3. patching file Source/WebCore/dom/ContainerNode.cpp Hunk #3 FAILED at 885. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.cpp.rej patching file Source/WebCore/dom/ContainerNode.h Hunk #1 FAILED at 145. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/86099 Created attachment 259617 [details]
Patch
Comment on attachment 259617 [details] Patch Clearing flags on attachment: 259617 Committed r188754: <http://trac.webkit.org/changeset/188754> All reviewed patches have been landed. Closing bug. |