Bug 148287

Summary: Have more getElementsBy*() methods return a Ref<>
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, kangil.han, koivisto, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-08-20 21:23:46 PDT
Have more getElementsBy*() methods return a Ref<> instead of a RefPtr<>.
Attachments
Patch (4.78 KB, patch)
2015-08-20 21:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2015-08-21 09:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-08-20 21:25:48 PDT
Created attachment 259582 [details] Patch
WebKit Commit Bot
Comment 2 2015-08-21 08:53:41 PDT
Comment on attachment 259582 [details] Patch Rejecting attachment 259582 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 259582, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ed at 1 with fuzz 3. patching file Source/WebCore/dom/ContainerNode.cpp Hunk #3 FAILED at 885. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.cpp.rej patching file Source/WebCore/dom/ContainerNode.h Hunk #1 FAILED at 145. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/ContainerNode.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Sam Weinig']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/86099
Chris Dumez
Comment 3 2015-08-21 09:04:47 PDT
Created attachment 259617 [details] Patch
Chris Dumez
Comment 4 2015-08-21 09:05:28 PDT
Comment on attachment 259617 [details] Patch Clearing flags on attachment: 259617 Committed r188754: <http://trac.webkit.org/changeset/188754>
Chris Dumez
Comment 5 2015-08-21 09:05:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.