Summary: | DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 145204 | ||||||
Attachments: |
|
Description
Filip Pizlo
2015-08-20 20:37:10 PDT
Created attachment 259581 [details]
the patch
Comment on attachment 259581 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259581&action=review > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79 > + if (m_state.forNode(edge).m_type & ~BooleanUse) Fishy. Is that BooleanUse right? (In reply to comment #2) > Comment on attachment 259581 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259581&action=review > > > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79 > > + if (m_state.forNode(edge).m_type & ~BooleanUse) > > Fishy. Is that BooleanUse right? Yeah. :-) Fixed locally. Landed in http://trac.webkit.org/changeset/188747 |