Bug 148286

Summary: DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145204    
Attachments:
Description Flags
the patch benjamin: review+

Filip Pizlo
Reported 2015-08-20 20:37:10 PDT
Patch forthcoming.
Attachments
the patch (12.83 KB, patch)
2015-08-20 20:38 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-08-20 20:38:52 PDT
Created attachment 259581 [details] the patch
Benjamin Poulain
Comment 2 2015-08-20 20:47:52 PDT
Comment on attachment 259581 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=259581&action=review > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79 > + if (m_state.forNode(edge).m_type & ~BooleanUse) Fishy. Is that BooleanUse right?
Filip Pizlo
Comment 3 2015-08-20 20:56:11 PDT
(In reply to comment #2) > Comment on attachment 259581 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259581&action=review > > > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79 > > + if (m_state.forNode(edge).m_type & ~BooleanUse) > > Fishy. Is that BooleanUse right? Yeah. :-) Fixed locally.
Filip Pizlo
Comment 4 2015-08-20 21:00:02 PDT
Landed in http://trac.webkit.org/changeset/188747
Note You need to log in before you can comment on or make changes to this bug.