Bug 148286

Summary: DFG should have a KnownBooleanUse for cases where we are required to know that the child is a boolean and it's not OK to speculate
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, sam, sbarati
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145204    
Attachments:
Description Flags
the patch benjamin: review+

Description Filip Pizlo 2015-08-20 20:37:10 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2015-08-20 20:38:52 PDT
Created attachment 259581 [details]
the patch
Comment 2 Benjamin Poulain 2015-08-20 20:47:52 PDT
Comment on attachment 259581 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259581&action=review

> Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79
> +            if (m_state.forNode(edge).m_type & ~BooleanUse)

Fishy. Is that BooleanUse right?
Comment 3 Filip Pizlo 2015-08-20 20:56:11 PDT
(In reply to comment #2)
> Comment on attachment 259581 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259581&action=review
> 
> > Source/JavaScriptCore/dfg/DFGSafeToExecute.h:79
> > +            if (m_state.forNode(edge).m_type & ~BooleanUse)
> 
> Fishy. Is that BooleanUse right?

Yeah. :-)  Fixed locally.
Comment 4 Filip Pizlo 2015-08-20 21:00:02 PDT
Landed in http://trac.webkit.org/changeset/188747