| Summary: | REGRESSION (r188581): Web Inspector: Console user command isn't visible when it's expected to be | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
Created attachment 259568 [details]
Patch
Comment on attachment 259568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259568&action=review > Source/WebInspectorUI/ChangeLog:7 > + You should explain why this regressed, and why the fix is correct. > Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:288 > + this._lastCommited = ""; Please rename this to _lastCommitted. It is spelled incorrectly. =) Created attachment 259713 [details]
Patch
Comment on attachment 259713 [details] Patch Clearing flags on attachment: 259713 Committed r188862: <http://trac.webkit.org/changeset/188862> All reviewed patches have been landed. Closing bug. |
<button onclick="console.log('Clicked')">Click me</button> Steps: 1. > 1+1 2. Click the button 3. > 1+1 Expected: > 1+1 < 2 [Log] Clicked > 1+1 < 2 Actual: > 1+1 < 2 [Log] Clicked < 2 "> 1+1" before the last line is missing.