Bug 148264

Summary: Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2015-08-20 16:34:53 PDT
file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:233:26: CONSOLE ERROR Uncaught exception in inspector page while dispatching callback for command CSS.getComputedStyleForNode: TypeError: Attempted to assign to readonly property. linked@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStylePropertyEditorLink.js:85:25 _updateProperties@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:185:33 _updateSections@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:162:35 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:124:55 dispatchEventToListeners@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:131:17 _selectorChanged@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:231:38 _selectorChanged@[native code] select@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TreeOutline.js:1015:33 createSelectorItem@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:113:32 update@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleSelectorSection.js:163:36 refresh@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/VisualStyleDetailsPanel.js:107:41 _refreshPreservingScrollPosition@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/StyleDetailsPanel.js:151:21 nodeStylesRefreshed@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/StyleDetailsPanel.js:122:50 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:124:55 dispatchEventToListeners@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Base/Object.js:131:17 fetchedComputedStyle@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Models/DOMNodeStyles.js:235:42 fetchedComputedStyle@[native code] _dispatchResponseToCallback@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:231:27 _dispatchResponse@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:203:45 dispatch@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:85:35 dispatchNextQueuedMessageFromBackend@file:///Volumes/Data/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Protocol/MessageDispatcher.js:42:34
Attachments
Patch (1.96 KB, patch)
2015-08-20 16:37 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-20 16:35:24 PDT
<rdar://problem/22371334>
Devin Rousso
Comment 2 2015-08-20 16:37:19 PDT
Created attachment 259521 [details] Patch
WebKit Commit Bot
Comment 3 2015-08-20 18:39:06 PDT
Comment on attachment 259521 [details] Patch Clearing flags on attachment: 259521 Committed r188731: <http://trac.webkit.org/changeset/188731>
WebKit Commit Bot
Comment 4 2015-08-20 18:39:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.