Bug 148243

Summary:

Web Inspector: Add flex alignment section to Visual sidebar

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

147563

Attachments:

Description	Flags
Patch	none

Description Devin Rousso 2015-08-20 14:04:51 PDT

Currently, the layout properties for flex box have visual editors, but the alignment (align, justify, etc.) properties do not.

Comment 1 Radar WebKit Bug Importer 2015-08-20 14:05:54 PDT

<rdar://problem/22367976>

Comment 2 Devin Rousso 2015-08-20 16:30:01 PDT

Created attachment 259517 [details]
Patch

Comment 3 Timothy Hatcher 2015-08-20 17:12:32 PDT

Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])

Really advanced? I could see this being in the basic list.

Comment 4 Devin Rousso 2015-08-20 17:13:30 PDT

Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
>> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])
> 
> Really advanced? I could see this being in the basic list.

I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox.  Since Grid is much less supported than Flexbox, I don't want the users getting confused.

Comment 5 Timothy Hatcher 2015-08-20 17:14:16 PDT

Comment on attachment 259517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259517&action=review

>>> Source/WebInspectorUI/UserInterface/Views/VisualStyleDetailsPanel.js:590
>>> +            advanced: advancedAlignmentKeywords.concat(["Space Evenly"])
>> 
>> Really advanced? I could see this being in the basic list.
> 
> I put it in the advanced list because it is a CSS Grid layout keyword and doesn't work for Flexbox.  Since Grid is much less supported than Flexbox, I don't want the users getting confused.

Makes sense.

Comment 6 WebKit Commit Bot 2015-08-20 18:42:31 PDT

Comment on attachment 259517 [details]
Patch

Clearing flags on attachment: 259517

Committed r188733: <http://trac.webkit.org/changeset/188733>

Comment 7 WebKit Commit Bot 2015-08-20 18:42:34 PDT

All reviewed patches have been landed.  Closing bug.