Bug 148240

Summary: [Win] Miscellaneous Windows Cleanups
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dino
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: All   
Bug Depends on: 148001    
Bug Blocks: 148249, 148275    
Attachments:
Description Flags
Patch dino: review+

Description Brent Fulgham 2015-08-20 13:38:35 PDT 
After Bug 148001 (r188662), I noticed a few more places where cleanups are needed:

1. STDMETHODCALLTYPE should never appear in a method implementation (only in the declaration).
2. Release(void) -> Release()
3. C++14 member initializers
4. 0 -> nullptr

This patch corrects these issues.
Comment 1 Brent Fulgham 2015-08-20 13:50:43 PDT 
Created attachment 259488 [details]
Patch
Comment 2 Dean Jackson 2015-08-20 13:52:22 PDT 
Comment on attachment 259488 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2015-08-20 13:52:54 PDT 
Attachment 259488 [details] did not pass style-queue:


ERROR: Source/WebKit/win/AccessibleBase.cpp:435:  AccessibleBase::get_accDescription is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/win/AccessibleBase.cpp:454:  AccessibleBase::get_accRole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/win/AccessibleBase.cpp:672:  AccessibleBase::get_accSelection is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/win/AccessibleBase.cpp:677:  AccessibleBase::get_accFocus is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit/win/AccessibleBase.cpp:703:  AccessibleBase::get_accDefaultAction is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brent Fulgham 2015-08-20 14:37:03 PDT 
Committed r188703: <http://trac.webkit.org/changeset/188703>