Bug 148238

Summary: Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0xFFFFFFFF
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, darin, koivisto, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#document
Bug Depends on:    
Bug Blocks: 148257    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-08-20 12:50:29 PDT
Default value for createNodeIterator() / createTreeWalker()'s whatToShow parameter should be 0xFFFFFFFF not 0 as per the specification: https://dom.spec.whatwg.org/#document Chrome and Firefox conform to the specification. Test suite: http://w3c-test.org/dom/traversal/NodeIterator.html http://w3c-test.org/dom/traversal/TreeWalker.html
Attachments
Patch (19.47 KB, patch)
2015-08-20 14:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.21 KB, patch)
2015-08-20 15:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-08-20 14:47:54 PDT
Created attachment 259501 [details] Patch
Ryosuke Niwa
Comment 2 2015-08-20 15:28:43 PDT
Comment on attachment 259501 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259501&action=review > Source/WebCore/dom/Document.idl:93 > + [ObjCLegacyUnnamedParameters] NodeIterator createNodeIterator(Node root, > + optional unsigned long whatToShow, > + optional NodeFilter? filter, > + optional boolean expandEntityReferences); > + [ObjCLegacyUnnamedParameters] TreeWalker createTreeWalker(Node root, > + optional unsigned long whatToShow, > + optional NodeFilter? filter, > + optional boolean expandEntityReferences); Can we use WebKit-style indentation (indent by 4 spaces)?
Chris Dumez
Comment 3 2015-08-20 15:31:30 PDT
Created attachment 259509 [details] Patch
Chris Dumez
Comment 4 2015-08-20 15:32:17 PDT
Comment on attachment 259509 [details] Patch Clearing flags on attachment: 259509 Committed r188711: <http://trac.webkit.org/changeset/188711>
Chris Dumez
Comment 5 2015-08-20 15:32:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.