Bug 148229

Summary: dispatch_group_t objects may not be retained properly when not backed by Objective-C objects under garbage collection
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: MediaAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, bfulgham, commit-queue, eric.carlson, jeremyj-wk, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2015-08-20 10:06:25 PDT 
dispatch_group_t objects may not be retained properly when not backed by Objective-C objects under garbage collection.

The proper way to address this is to use OSObjectPtr<>, which does the right thing regardless of whether the dispatch_group_t objects are backed by Objective-C objects or not.
Comment 1 David Kilzer (:ddkilzer) 2015-08-21 10:35:12 PDT 
Created attachment 259630 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2015-08-21 10:43:15 PDT 
Comment on attachment 259630 [details]
Patch

I forgot to include the header!
Comment 3 David Kilzer (:ddkilzer) 2015-08-21 10:44:54 PDT 
Created attachment 259631 [details]
Patch v2
Comment 4 WebKit Commit Bot 2015-08-21 11:37:40 PDT 
Comment on attachment 259631 [details]
Patch v2

Clearing flags on attachment: 259631

Committed r188761: <http://trac.webkit.org/changeset/188761>
Comment 5 WebKit Commit Bot 2015-08-21 11:37:43 PDT 
All reviewed patches have been landed.  Closing bug.