Bug 148212

Summary:

Web Inspector: Truncate data URIs

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Animated GIF] Bug	none
[Animated GIF] With the patch applied	none
Patch	none
Patch	timothy: review-
[Animated GIF] With the patch applied	none
Patch	timothy: review+
Patch	none

Nikita Vasilyev

Reported 2015-08-19 21:49:07 PDT

Created attachment 259446 [details] [Animated GIF] Bug Data URI can be megabytes in size, we shouldn't display them as is. Test case: data:text/html;base64,<!DOCTYPE html>
<html>
<head>
    <meta charset="UTF-8">
    <title>Base64 test</title>
    <link rel="stylesheet" href="data:text/css;base64,@charset "UTF-8";*{box-sizing:border-box}html,body{height:100%}body{font:87.5%/1.5 Verdana,"Helvetica Neue",Arial,sans-serif;background:#e4e7f1;color:#333;tab-size:2;-moz-tab-size:2;margin:0;position:relative}h1,h2,h3,h4,h5,h6{font-family:Georgia,Marion,Kefa,serif;line-height:1.2}h2{font-size:150%;font-weight:normal;margin:1em 0 .5em}h3{font-size:100%;font-weight:normal;margin:1.25em 0 .75em;text-transform:uppercase;letter-spacing:.1em}h4{font-size:100%;font-weight:bold;margin:1.25em 0 .75em}p,ul,ol,dl,blockquote{margin:0 0 0.75em}p,li,dl,blockquote{max-width:600px}dd{margin-bottom:.25em}input,button,select{font-size:13px}input[type=checkbox],input[type=radio],input[type=range]{font-size:16px}code{font-family:Consolas,Menlo,monospace;font-size:92.85%}pre>code{font-size:13px}th{font-family:Georgia,Marion,Kefa,serif;text-align:left;vertical-align:top;padding-right:1em}td{vertical-align:top}pre{margin:0 0 0.75em;white-space:pre-wrap}pre i{font-style:normal}blockquote{padding-left:2.1em;color:#666}blockquote:before{content:'“';float:left;font:300% Georgia,Marion,Kefa,serif;margin-top:-0.05em;text-indent:-0.6em}abbr{letter-spacing:.05em}kbd{font-size:13px;font-family:"Helvetica Neue",Arial,sans-serif;padding:0 0.5em;background-color:#f7f7f7;color:#333;box-shadow:0 1px 0 rgba(0,0,0,0.1),0 0 0 1px #fff inset;border-radius:3px;display:inline-block;margin:-1px 0;white-space:nowrap;border:1px solid #c9c9c9;border-bottom-color:#AAA;border-top-color:#dbdbdb}kbd+kbd{margin-left:-.2em}var{font-style:normal}samp{font-size:inherit}.list-header{margin-bottom:0em}#content{min-height:100%}a:link{color:#0e72ce}a:visited{color:#8f65a1}a:hover,a:focus{color:#0085ff}a:active{color:#8f65a1}#top,.entry-title,.entry-excerpt,.entry-more{padding-left:6%;padding-left:8vw;padding-right:6%;padding-right:8vw}article{overflow:hidden;position:relative;border-bottom:1px solid #CCC;border-top:1px solid #F9F9F9;background:#eee;-webkit-transition-duration:0.2s;-moz-transition-duration:0.2s;-o-transition-duration:0.2s;transition-duration:0.2s;-webkit-transition-timing-function:ease-out;-moz-transition-timing-function:ease-out;-o-transition-timing-function:ease-out;transition-timing-function:ease-out;-webkit-transition-property:opacity;-moz-transition-property:opacity;-o-transition-property:opacity;transition-property:opacity}#top{font-family:Georgia,Marion,Kefa,serif;padding-top:.6em;padding-bottom:.6em;border-bottom:1px solid #ced3e4;background:#e4e7f1;color:#667399}.view-home #top{-webkit-transition-duration:0.2s;-moz-transition-duration:0.2s;-o-transition-duration:0.2s;transition-duration:0.2s;-webkit-transition-timing-function:ease-out;-moz-transition-timing-function:ease-out;-o-transition-timing-function:ease-out;transition-timing-function:ease-out;-webkit-transition-property:background-color, font-size, border-bottom-color;-moz-transition-property:background-color, font-size, border-bottom-color;-o-transition-property:background-color, font-size, border-bottom-color;transition-property:background-color, font-size, border-bottom-color}.view-home-done .entry-more{display:none}#title{text-decoration:none;display:inline-block;padding:0;margin:0;white-space:nowrap}.entry-title{font:180%/1.2 Georgia,Marion,Kefa,serif normal normal;margin:0;padding-top:24px;padding-bottom:18px;vertical-align:top;color:#000;-webkit-transition-property:font-size, line-height, padding-top, padding-bottom;-moz-transition-property:font-size, line-height, padding-top, padding-bottom;-o-transition-property:font-size, line-height, padding-top, padding-bottom;transition-property:font-size, line-height, padding-top, padding-bottom;-webkit-transition-duration:0.2s;-moz-transition-duration:0.2s;-o-transition-duration:0.2s;transition-duration:0.2s;-webkit-transition-timing-function:ease-out;-moz-transition-timing-function:ease-out;-o-transition-timing-function:ease-out;transition-timing-function:ease-out}.entry-link{text-decoration:none;border-bottom:1px solid}.entry-link:link{border-bottom-color:#79acdf}.entry-link:visited{border-bottom-color:#b9a6c9}.entry-link:hover,.entry-link:focus{border-bottom-color:#72b6f8}.entry-link:active{border-bottom-color:#b9a6c9}.entry-excerpt{margin-bottom:2em;-webkit-transition-property:margin-bottom;-moz-transition-property:margin-bottom;-o-transition-property:margin-bottom;transition-property:margin-bottom;-webkit-transition-duration:0.2s;-moz-transition-duration:0.2s;-o-transition-duration:0.2s;transition-duration:0.2s;-webkit-transition-timing-function:linear;-moz-transition-timing-function:linear;-o-transition-timing-function:linear;transition-timing-function:linear}.entry-excerpt>h2:first-child{margin-top:.5em}.entry-more{overflow:hidden;height:0}.article-current .entry-title{font-size:250%;padding-top:32px;padding-bottom:24px}.article-current .entry-link{border-bottom-color:#eee}.article-current .entry-excerpt{margin-bottom:.75em}.article-current .entry-more{height:auto}.view-home #title,.article-current .entry-link{color:#000;cursor:auto;pointer-events:none}#headline{color:#667399}.view-home #top{font-size:150%}.view-page-done article:not(.article-current){display:none}.view-page-done #about,.view-page-done #headline{display:none}.view-page-done .entry-more{overflow:auto}.shell-prompt:before,.terminal code:before{content:'$ ';color:#999}#about{overflow:hidden;font-size:75%}#about,#about li{margin-left:0;padding-left:0;list-style:none}#about li{display:inline-block;margin-right:12px}#services{margin:0;padding:0}#me del{display:none}.meta{margin:1.5em 0 0;color:#999;font-family:Georgia,Marion,Kefa,serif}.meta>address{display:inline;font-style:normal}.full-width,.appendix{box-sizing:content-box;padding-left:6%;padding-left:8vw;padding-right:6%;padding-right:8vw;width:100%;margin-left:-6%;margin-left:-8vw}.appendix{background:#e4e7f1;border-top:1px solid #ced3e4;margin-top:1.5em;padding-top:1.5em;min-height:365px}.comments{max-width:800px}.image-toggle{box-shadow:0 0 1px #ced3e4;box-sizing:content-box;transition-property:width, margin-left;transition-duration:.4s;transition-timing-function:cubic-bezier(0, 0.9, 0.2, 1)}.image-toggle:hover,.image-toggle:focus{box-shadow:0 0 1px #667399}.js .image-toggle-min{cursor:zoom-in;cursor:-webkit-zoom-in;margin-left:0}.js .image-toggle-max{cursor:zoom-out;cursor:-webkit-zoom-out;margin-left:-8vw}video{cursor:pointer}video:hover,.video-paused{box-shadow:0 0 1px #667399}hr{background:none;border-width:0;border-bottom:1px solid #DDD;margin:1.5em 0;max-width:600px}.page-error{background:#f8e2ef}.pixelated{image-rendering:optimizeSpeed;image-rendering:-moz-crisp-edges;image-rendering:-webkit-optimize-contrast;image-rendering:optimize-contrast;image-rendering:crisp-edges;image-rendering:pixelated;-ms-interpolation-mode:nearest-neighbor}@media (max-width: 1000px){pre>code{font-size:12px}}@media (max-width: 700px){pre>code{font-size:11px}}"/>
</head>
<body onload="console.log('loaded')">
Base64 test
<p><button onclick="console.log(Math.random())">Math.random()</button></p>
<script src="data:text/javascript;base64,LyogdGVzdCBqYXZhc2NyaXB0ICovDQoNCndpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oZSkgew0KICAgIGNvbnNvbGUudHJhY2UoKTsNCiAgICBjb25zb2xlLmluZm8oIkxvYWRlZCBmcm9tIHNvdXJjZS11cmwuanMiKTsNCn0pOw0KDQovLyMgc291cmNlVVJMPXNvdXJjZS11cmwuanM="></script>
</body>
</html>

Attachments
[Animated GIF] Bug (1.33 MB, image/gif) 2015-08-19 21:49 PDT, Nikita Vasilyev	no flags	Details
[Animated GIF] With the patch applied (483.26 KB, image/gif) 2015-08-19 22:26 PDT, Nikita Vasilyev	no flags	Details
Patch (5.95 KB, patch) 2015-08-19 22:37 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Patch (6.19 KB, patch) 2015-08-19 23:07 PDT, Nikita Vasilyev	timothy: review-	Details Formatted Diff Diff
[Animated GIF] With the patch applied (378.02 KB, image/gif) 2015-08-19 23:17 PDT, Nikita Vasilyev	no flags	Details
Patch (6.55 KB, patch) 2015-08-20 01:14 PDT, Nikita Vasilyev	timothy: review+	Details Formatted Diff Diff
Patch (6.19 KB, patch) 2015-08-20 17:15 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-08-19 21:49:27 PDT

<rdar://problem/22356591>

Nikita Vasilyev

Comment 2 2015-08-19 22:26:11 PDT

(In reply to comment #0) > Created attachment 259446 [details] > [Animated GIF] Bug You couldn't see it there, but the title popovers went all the way to the upper edge of my screen.

Nikita Vasilyev

Comment 3 2015-08-19 22:26:43 PDT

Created attachment 259449 [details] [Animated GIF] With the patch applied

Nikita Vasilyev

Comment 4 2015-08-19 22:37:36 PDT

Created attachment 259450 [details] Patch

Nikita Vasilyev

Comment 5 2015-08-19 23:07:35 PDT

Created attachment 259452 [details] Patch

Nikita Vasilyev

Comment 6 2015-08-19 23:17:25 PDT

Created attachment 259453 [details] [Animated GIF] With the patch applied

Timothy Hatcher

Comment 7 2015-08-19 23:37:03 PDT

Comment on attachment 259452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259452&action=review > Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:213 > +WebInspector.displayDataUri = function(uri) URI > Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:219 > + else No else after a return. > Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:220 > + return matched[1] + "â¦" + uri.slice(-3); Should escape the ellipsis. > Source/WebInspectorUI/UserInterface/Models/Resource.js:126 > + get displayUrl() URL > Source/WebInspectorUI/UserInterface/Models/Resource.js:128 > + if (this._url.startsWith("data:")) { Why two different approaches? > Source/WebInspectorUI/UserInterface/Models/Resource.js:134 > + else No else after a return. > Source/WebInspectorUI/UserInterface/Models/Resource.js:136 > + } else Ditto. > Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js:336 > + let displayUrl = sourceCode.displayUrl; Can this use the global function you added?

Nikita Vasilyev

Comment 8 2015-08-19 23:54:07 PDT

Comment on attachment 259452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259452&action=review >> Source/WebInspectorUI/UserInterface/Models/Resource.js:128 >> + if (this._url.startsWith("data:")) { > > Why two different approaches? Good question. I only now noticed that this code is almost the same as WebInspector.displayDataUri. This method is used to display tooltips. There are two differences: — An extra line break after the header for displayDataUri, e.g. "data:text/css;base64,", which only makes sense for tooltips. — Preview size: 64 chars for displayUrl and 6 chars for WebInspector.displayDataUri. I'll rewrite this.

Nikita Vasilyev

Comment 9 2015-08-20 01:14:27 PDT

Created attachment 259457 [details] Patch

Timothy Hatcher

Comment 10 2015-08-20 06:28:31 PDT

Comment on attachment 259457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259457&action=review > Source/WebInspectorUI/UserInterface/Base/URLUtilities.js:213 > +WebInspector.truncateURL = function(url, multiline=false, dataURIMaxSize=6) We are putting spaces around default argument assignments. > Source/WebInspectorUI/UserInterface/Models/Resource.js:666 > +WebInspector.Resource.DataURIMaxSize = 64; Could just inline as a const. > Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js:336 > + const displayUrl = sourceCode.displayURL; URL

Nikita Vasilyev

Comment 11 2015-08-20 17:15:29 PDT

Created attachment 259535 [details] Patch

WebKit Commit Bot

Comment 12 2015-08-20 19:34:44 PDT

Comment on attachment 259535 [details] Patch Clearing flags on attachment: 259535 Committed r188739: <http://trac.webkit.org/changeset/188739>

WebKit Commit Bot

Comment 13 2015-08-20 19:34:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.