Bug 148203

Summary: clearCode() should clear code
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: REOPENED ---    
Severity: Normal CC: barraclough, cdumez, commit-queue, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 148244    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Geoffrey Garen 2015-08-19 16:52:55 PDT
clearCode() should clear code
Comment 1 Geoffrey Garen 2015-08-19 16:55:25 PDT
Created attachment 259429 [details]
Patch
Comment 2 Saam Barati 2015-08-19 17:00:29 PDT
Comment on attachment 259429 [details]
Patch

r=me
Comment 3 Geoffrey Garen 2015-08-19 18:18:51 PDT
Comment on attachment 259429 [details]
Patch

Clearing flags on attachment: 259429

Committed r188675: <http://trac.webkit.org/changeset/188675>
Comment 4 Geoffrey Garen 2015-08-19 18:18:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2015-08-20 10:55:47 PDT
This change seems to have regressed the PLT on Mac by ~17%. Please fix or roll out ASAP.
Comment 6 Chris Dumez 2015-08-20 12:34:12 PDT
(In reply to comment #5)
> This change seems to have regressed the PLT on Mac by ~17%. Please fix or
> roll out ASAP.

And looks like a ~3% PLT regression on iPad as well.
Comment 7 WebKit Commit Bot 2015-08-20 14:05:46 PDT
Re-opened since this is blocked by bug 148244
Comment 8 Chris Dumez 2015-08-20 20:54:47 PDT
Thanks for rolling out, the PLT recovered.