Bug 148202

Summary:

Add some new emoji with modifiers and new sequence

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

HTML Editing

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, mmaxfield, ossy, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

148479

Bug Blocks:

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Patch2	sam: review+
Patch3	none

Enrica Casucci

Reported 2015-08-19 16:52:39 PDT

Supporting some new emoji with modifiers. rdar://problem/21849857

Attachments
Patch (14.04 KB, patch) 2015-08-20 14:08 PDT, Enrica Casucci	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-mavericks (426.93 KB, application/zip) 2015-08-20 14:41 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (434.32 KB, application/zip) 2015-08-20 14:43 PDT, Build Bot	no flags	Details
Patch2 (15.92 KB, patch) 2015-08-26 02:19 PDT, Enrica Casucci	sam: review+	Details Formatted Diff Diff
Patch3 (17.29 KB, patch) 2015-08-27 06:44 PDT, Enrica Casucci	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Enrica Casucci

Comment 1 2015-08-20 14:08:56 PDT

Created attachment 259492 [details] Patch

Build Bot

Comment 2 2015-08-20 14:41:11 PDT

Comment on attachment 259492 [details] Patch Attachment 259492 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/80706 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2015-08-20 14:41:15 PDT

Created attachment 259499 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 4 2015-08-20 14:43:17 PDT

Comment on attachment 259492 [details] Patch Attachment 259492 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/80708 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2015-08-20 14:43:20 PDT

Created attachment 259500 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Enrica Casucci

Comment 6 2015-08-26 02:19:47 PDT

Created attachment 259941 [details] Patch2

Sam Weinig

Comment 7 2015-08-26 02:23:32 PDT

Comment on attachment 259941 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=259941&action=review > LayoutTests/ChangeLog:25 > +2015-08-26 Enrica Casucci <enrica@apple.com> > + > + Add some new emoji with modifiers and new sequence. > + https://bugs.webkit.org/show_bug.cgi?id=148202 > + rdar://problem/21849857 > + > + Reviewed by NOBODY (OOPS!). > + > + Updated test to reflect the changes. > + > + * editing/deleting/delete-emoji-expected.txt: > + * editing/deleting/delete-emoji.html: > + > +2015-08-25 Enrica Casucci <enrica@apple.com> > + > + Add some new emoji with modifiers and new sequence. > + https://bugs.webkit.org/show_bug.cgi?id=148202 > + rdar://problem/21849857 > + > + Reviewed by NOBODY (OOPS!). > + > + Test updated to test the new emoji and the new sequence. > + > + * editing/deleting/delete-emoji-expected.txt: > + * editing/deleting/delete-emoji.html: Double changelog.

Enrica Casucci

Comment 8 2015-08-26 02:26:45 PDT

Committed revision 188960.

Csaba Osztrogonác

Comment 9 2015-08-26 05:23:09 PDT

(In reply to comment #8) > Committed revision 188960. It made zillion tests crash on all bots, see build.webkit.org for details.

Enrica Casucci

Comment 10 2015-08-26 06:20:27 PDT

I don't see any crashlogs unfortunately. I'll take a look at what happens.

Csaba Osztrogonác

Comment 11 2015-08-26 06:27:03 PDT

(In reply to comment #10) > I don't see any crashlogs unfortunately. I'll take a look at what happens. Apple's debug buildbots do provide crashlogs: https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/r188960%20%2815165%29/results.html https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/r188960%20%2814058%29/results.html https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20%28Tests%29/r188960%20%287034%29/results.html https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/r188960%20%286531%29/results.html

Enrica Casucci

Comment 12 2015-08-26 06:56:13 PDT

(In reply to comment #11) > (In reply to comment #10) > > I don't see any crashlogs unfortunately. I'll take a look at what happens. > > Apple's debug buildbots do provide crashlogs: > https://build.webkit.org/results/ > Apple%20Mavericks%20Debug%20WK1%20%28Tests%29/r188960%20%2815165%29/results. > html > https://build.webkit.org/results/ > Apple%20Mavericks%20Debug%20WK2%20%28Tests%29/r188960%20%2814058%29/results. > html > https://build.webkit.org/results/ > Apple%20Yosemite%20Debug%20WK1%20%28Tests%29/r188960%20%287034%29/results. > html > https://build.webkit.org/results/ > Apple%20Yosemite%20Debug%20WK2%20%28Tests%29/r188960%20%286531%29/results. > html I found them in our internal bots too. I'm investigating.

WebKit Commit Bot

Comment 13 2015-08-26 08:50:27 PDT

Re-opened since this is blocked by bug 148479

Enrica Casucci

Comment 14 2015-08-27 06:44:18 PDT

Created attachment 260053 [details] Patch3

Enrica Casucci

Comment 15 2015-08-27 08:16:28 PDT

Committed revision 189024.

Note You need to log in before you can comment on or make changes to this bug.