| Summary: | Standalone image documents should send their size to the UIClient just like standalone media documents | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, bdakin, calvaris, cgarcia, commit-queue, esprehn+autocc, gyuyoung.kim, ossy, thorton | ||||||
| Priority: | P2 | ||||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 148279, 148424 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Beth Dakin
2015-08-19 15:00:56 PDT
Created attachment 259410 [details]
Patch
Created attachment 259420 [details]
Patch
Comment on attachment 259420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259420&action=review > Source/WebCore/page/ChromeClient.h:459 > + virtual void imageDocumentSizeChanged(const WebCore::IntSize&) { } > #if ENABLE(VIDEO) > virtual void mediaDocumentNaturalSizeChanged(const WebCore::IntSize&) { } Any reason these aren't combined? Thanks Tim! http://trac.webkit.org/changeset/188693 This commit is breaking (at least) GTK+ compilation. (In reply to comment #5) > This commit is breaking (at least) GTK+ compilation. Do you have a build failure log? (In reply to comment #6) > (In reply to comment #5) > > This commit is breaking (at least) GTK+ compilation. > > Do you have a build failure log? It seems that this problem got fixed somehow. Now the problem is another unrelated one. Just to document, the EFL build was fixed by https://trac.webkit.org/changeset/188738 and the GTK was fixed by https://trac.webkit.org/changeset/188740 |