Bug 148193

Summary: Avoid double hash lookup in our JS bindings named property getter code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, bfulgham, commit-queue, ggaren, rniwa
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148092
Bug Depends on: 148425    
Bug Blocks: 148209    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2015-08-19 14:53:35 PDT
Avoid double hash lookup in our JS bindings named property getter code for performance reasons.
Attachments
Patch (56.62 KB, patch)
2015-08-19 14:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (59.75 KB, patch)
2015-08-19 15:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-08-19 14:58:14 PDT
Created attachment 259409 [details] Patch
Chris Dumez
Comment 2 2015-08-19 15:30:17 PDT
Created attachment 259415 [details] Patch
Geoffrey Garen
Comment 3 2015-08-19 16:04:00 PDT
Comment on attachment 259415 [details] Patch r=me I wonder if Dromaeo will be faster now.
WebKit Commit Bot
Comment 4 2015-08-19 17:06:39 PDT
Comment on attachment 259415 [details] Patch Clearing flags on attachment: 259415 Committed r188663: <http://trac.webkit.org/changeset/188663>
WebKit Commit Bot
Comment 5 2015-08-19 17:06:43 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 6 2015-08-19 18:00:58 PDT
This broke the Windows build (see the EWS output? :-) ) The new file "bindings/js/JSDOMNamedFlowCollectionCustom.cpp" needed to be added to the JSBindingsAllInOne.cpp file, since the project settings told MSVC to not build the new file. Fix landed in r188674.
Chris Dumez
Comment 7 2015-08-19 19:02:22 PDT
(In reply to comment #6) > This broke the Windows build (see the EWS output? :-) ) > > The new file "bindings/js/JSDOMNamedFlowCollectionCustom.cpp" needed to be > added to the JSBindingsAllInOne.cpp file, since the project settings told > MSVC to not build the new file. > > Fix landed in r188674. Sorry, I thought I had fixed it but I forgot about JSBindingsAllInOne.cpp.
Note You need to log in before you can comment on or make changes to this bug.