| Summary: | Web Inspector: Unexpected node preview format for an element with newlines in className attribute | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 259407 [details]
[PATCH] Proposed Fix
Though this may not technically be not accurate for XML, I think this is fine.
Comment on attachment 259407 [details]
[PATCH] Proposed Fix
r=me
It's conceivable that other attributes might need the same sanitization. If we do that, then the sanitizer should be extracted.
Comment on attachment 259407 [details] [PATCH] Proposed Fix Clearing flags on attachment: 259407 Committed r188656: <http://trac.webkit.org/changeset/188656> All reviewed patches have been landed. Closing bug. |
* SUMMARY Unexpected node preview format for an element with newlines in className attribute * STEPS TO REPRODUCE 1. js> div = document.createElement("div"); div.className = "one\ntwo"; [div] * EXPECTED <div class="one two"> (syntax highlighted) * ACTUAL <div class="one two"> (not syntax highlighted)