Bug 148192

Summary:

Web Inspector: Unexpected node preview format for an element with newlines in className attribute

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Joseph Pecoraro

Reported 2015-08-19 14:33:04 PDT

* SUMMARY Unexpected node preview format for an element with newlines in className attribute * STEPS TO REPRODUCE 1. js> div = document.createElement("div"); div.className = "one\ntwo"; [div] * EXPECTED <div class="one two"> (syntax highlighted) * ACTUAL <div class="one two"> (not syntax highlighted)

Attachments
[PATCH] Proposed Fix (1.62 KB, patch) 2015-08-19 14:36 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2015-08-19 14:36:03 PDT

Created attachment 259407 [details] [PATCH] Proposed Fix Though this may not technically be not accurate for XML, I think this is fine.

Blaze Burg

Comment 2 2015-08-19 14:46:41 PDT

Comment on attachment 259407 [details] [PATCH] Proposed Fix r=me It's conceivable that other attributes might need the same sanitization. If we do that, then the sanitizer should be extracted.

WebKit Commit Bot

Comment 3 2015-08-19 15:33:20 PDT

Comment on attachment 259407 [details] [PATCH] Proposed Fix Clearing flags on attachment: 259407 Committed r188656: <http://trac.webkit.org/changeset/188656>

WebKit Commit Bot

Comment 4 2015-08-19 15:33:23 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.