Bug 148189

Summary: [GTK] Auto-detection of cairo-gl fails
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Gustavo Noronha (kov) 2015-08-19 13:46:54 PDT 
[GTK] Auto-detection of cairo-gl fails
Comment 1 Gustavo Noronha (kov) 2015-08-19 13:50:00 PDT 
Created attachment 259401 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2015-08-19 13:53:19 PDT 
A bit more detail: ACCELERATED_2D_CANVAS was being enabled in my Debian-based OS even with no cairo-gl. It turned out CAIROGL_FOUND was true when cairo-glx or cairo-egl were available even if cairo-gl was not. After fixing that I noticed the call to set the default was failing because the variable was being "evaluated" to its string form using ${}, which ends up being empty.
Comment 3 Zan Dobersek 2015-08-20 00:47:45 PDT 
Comment on attachment 259401 [details]
Patch

r=me
Comment 4 Gustavo Noronha (kov) 2015-08-20 06:57:55 PDT 
Comment on attachment 259401 [details]
Patch

ffe6c129dc88661561ab30ea831696c3aab99a4b
Comment 5 Gustavo Noronha (kov) 2015-08-20 06:58:36 PDT 
Comment on attachment 259401 [details]
Patch

http://trac.webkit.org/changeset/188685