Bug 148185

Summary: Web Inspector: long selectors in the visual editor sidebar can overflow
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
URL: http://www.apple.com/
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Overflowing selectors
none
Patch none

Blaze Burg
Reported 2015-08-19 13:27:11 PDT
They should be wrapped. We may have to add some &zwsp; to make it work as expected.
Attachments
Overflowing selectors (78.79 KB, image/png)
2015-08-19 13:28 PDT, Blaze Burg 		no flags
Details
Patch (4.00 KB, patch)
2015-08-19 15:57 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-19 13:27:28 PDT
<rdar://problem/22349071>
Blaze Burg
Comment 2 2015-08-19 13:28:04 PDT
Created attachment 259394 [details] Overflowing selectors
Timothy Hatcher
Comment 3 2015-08-19 13:29:48 PDT
I don't think wrapping is right. The rows should be a constant height. I think the tooltip should show the whole thing, but we should truncate the selector with an ellipsis.
Devin Rousso
Comment 4 2015-08-19 15:57:12 PDT
Created attachment 259422 [details] Patch
WebKit Commit Bot
Comment 5 2015-08-19 17:27:38 PDT
Comment on attachment 259422 [details] Patch Clearing flags on attachment: 259422 Committed r188667: <http://trac.webkit.org/changeset/188667>
WebKit Commit Bot
Comment 6 2015-08-19 17:27:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.