Bug 148185

Summary:

Web Inspector: long selectors in the visual editor sidebar can overflow

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

URL:

http://www.apple.com/

Bug Depends on:

Bug Blocks:

147563

Attachments:

Description	Flags
Overflowing selectors	none
Patch	none

Description BJ Burg 2015-08-19 13:27:11 PDT

They should be wrapped. We may have to add some &zwsp; to make it work as expected.

Comment 1 Radar WebKit Bug Importer 2015-08-19 13:27:28 PDT

<rdar://problem/22349071>

Comment 2 BJ Burg 2015-08-19 13:28:04 PDT

Created attachment 259394 [details]
Overflowing selectors

Comment 3 Timothy Hatcher 2015-08-19 13:29:48 PDT

I don't think wrapping is right. The rows should be a constant height. I think the tooltip should show the whole thing, but we should truncate the selector with an ellipsis.

Comment 4 Devin Rousso 2015-08-19 15:57:12 PDT

Created attachment 259422 [details]
Patch

Comment 5 WebKit Commit Bot 2015-08-19 17:27:38 PDT

Comment on attachment 259422 [details]
Patch

Clearing flags on attachment: 259422

Committed r188667: <http://trac.webkit.org/changeset/188667>

Comment 6 WebKit Commit Bot 2015-08-19 17:27:43 PDT

All reviewed patches have been landed.  Closing bug.