Bug 148165 – REGRESSION (r188581): Web Inspector: Option-Enter no longer inserts a new line in the console

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

Regression from: Web Inspector: Option-Enter should commit console command without erasing the prompt https://bugs.webkit.org/show_bug.cgi?id=148123

[Radar WebKit Bug Importer]

<rdar://problem/22338630>

[Nikita Vasilyev]

Shift-Enter and Control-Enter insert a line break.
Option-Enter used to insert a line break, but since r188581 it evaluates a command and keeps it in the prompt.
Command-Enter forces execution, e.g. "1+" would show an error.

Here is what I think we should do:

— Shift-Enter, Control-Enter, and Option-Enter should all insert a line break, as it was before r188581.
— Command-Enter should force execution AND keep the command in the prompt

If somebody uses force execution, sees a syntax error, it's very likely they would press Up and edit the previous command. We may as well save that Up keypress and not erase the prompt.

In fact, this is exactly how it works in Firebug multiline console — Command-Enter forces execution and keeps the command in the prompt.

[Nikita Vasilyev]

Created attachment 259359 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259359 [details]
Patch

Clearing flags on attachment: 259359

Committed r188635: <http://trac.webkit.org/changeset/188635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.