Bug 148159

Summary: Cleanup outline-style: auto painting.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2015-08-18 20:00:53 PDT
Remove pre-history logic and adjust html.css.
Comment 1 zalan 2015-08-18 20:02:45 PDT
Created attachment 259343 [details]
Patch
Comment 2 zalan 2015-08-18 20:03:10 PDT
EWS testing first.
Comment 3 zalan 2015-08-18 20:49:50 PDT
Created attachment 259344 [details]
Patch
Comment 4 Simon Fraser (smfr) 2015-08-19 12:10:58 PDT
Comment on attachment 259344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259344&action=review

> Source/WebCore/ChangeLog:8
> +        Old platform style required the focus ring to be painted with an offset.

Would be nice if you could be more specific about the history of the code (like to specific trac revisions).

> Source/WebCore/ChangeLog:12
> +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.

It also short-circuits RenderElement::paintOutline() when painting is disabled. Is that OK?
Comment 5 zalan 2015-08-19 14:29:25 PDT
Created attachment 259406 [details]
Patch
Comment 6 zalan 2015-08-19 14:31:11 PDT
(In reply to comment #4)
> Comment on attachment 259344 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259344&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Old platform style required the focus ring to be painted with an offset.
> 
> Would be nice if you could be more specific about the history of the code
> (like to specific trac revisions).
Done.

> 
> > Source/WebCore/ChangeLog:12
> > +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.
> 
> It also short-circuits RenderElement::paintOutline() when painting is
> disabled. Is that OK?
Focus ring painting is already short circuited the only behavior change is for non-auto outlines and I supposed they are not meant to be painted when painting is disabled.
Comment 7 WebKit Commit Bot 2015-08-19 15:09:36 PDT
Comment on attachment 259406 [details]
Patch

Clearing flags on attachment: 259406

Committed r188652: <http://trac.webkit.org/changeset/188652>
Comment 8 WebKit Commit Bot 2015-08-19 15:09:40 PDT
All reviewed patches have been landed.  Closing bug.