Bug 148159 – Cleanup outline-style: auto painting.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

Remove pre-history logic and adjust html.css.

[alan]

Created attachment 259343 [details]
Patch

[alan]

EWS testing first.

[alan]

Created attachment 259344 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 259344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259344&action=review

> Source/WebCore/ChangeLog:8
> +        Old platform style required the focus ring to be painted with an offset.

Would be nice if you could be more specific about the history of the code (like to specific trac revisions).

> Source/WebCore/ChangeLog:12
> +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.

It also short-circuits RenderElement::paintOutline() when painting is disabled. Is that OK?

[alan]

Created attachment 259406 [details]
Patch

[alan]

(In reply to comment #4)
> Comment on attachment 259344 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259344&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Old platform style required the focus ring to be painted with an offset.
> 
> Would be nice if you could be more specific about the history of the code
> (like to specific trac revisions).
Done.

> 
> > Source/WebCore/ChangeLog:12
> > +        This patch removes both the old logic and the workaround for getting rid of the unwanted offset.
> 
> It also short-circuits RenderElement::paintOutline() when painting is
> disabled. Is that OK?
Focus ring painting is already short circuited the only behavior change is for non-auto outlines and I supposed they are not meant to be painted when painting is disabled.

[WebKit Commit Bot]

Comment on attachment 259406 [details]
Patch

Clearing flags on attachment: 259406

Committed r188652: <http://trac.webkit.org/changeset/188652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.