Bug 148153

Summary: Web Inspector: Visual editor links should unlink when switching styles
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Patch none

Description Devin Rousso 2015-08-18 16:53:44 PDT
Currently, the editor links stay active until the user disables them, even when switching rules/nodes.  This should be changed such that the link deactivates whenever the rule/node changes to prevent unwanted syncing between editors.
Comment 1 Radar WebKit Bug Importer 2015-08-18 16:54:29 PDT
<rdar://problem/22335395>
Comment 2 Devin Rousso 2015-08-18 16:56:40 PDT
Created attachment 259322 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-18 17:04:21 PDT
Comment on attachment 259322 [details]
Patch

Maybe it should auto link if the values match?
Comment 4 Devin Rousso 2015-08-18 17:10:58 PDT
(In reply to comment #3)
> Maybe it should auto link if the values match?

I was tempted to add this, but I feel that that may be assuming too much about what the user intends to do.  If they really want to link the editors, they click the link to make that happen.
Comment 5 Timothy Hatcher 2015-08-18 17:12:36 PDT
Alright. Sounds good.
Comment 6 WebKit Commit Bot 2015-08-18 18:42:06 PDT
Comment on attachment 259322 [details]
Patch

Clearing flags on attachment: 259322

Committed r188621: <http://trac.webkit.org/changeset/188621>
Comment 7 WebKit Commit Bot 2015-08-18 18:42:10 PDT
All reviewed patches have been landed.  Closing bug.