Bug 148150

Summary: Web Inspector: transparent color swatches have lopsided checkered background on non-retina
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[IMAGE] Before
none
[IMAGE] After
none
[PATCH] Proposed Fix
timothy: review+
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-08-18 16:16:32 PDT
* SUMMARY "transparent" color swatches have lopsided checkered background on non-retina. * TEST data:text/html,<div%20style="color:transparent">Test</div> * STEPS TO REPRODUCE 1. Inspect <div> on test 2. View Styles > Rules => Color swatch for Transparent shows lopsided checkers
Attachments
[IMAGE] Before (5.28 KB, image/png)
2015-08-18 16:18 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (5.42 KB, image/png)
2015-08-18 16:18 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (1.70 KB, patch)
2015-08-18 16:19 PDT, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (2.21 KB, patch)
2015-08-18 17:02 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-18 16:17:40 PDT
<rdar://problem/22334640>
Joseph Pecoraro
Comment 2 2015-08-18 16:18:11 PDT
Created attachment 259309 [details] [IMAGE] Before
Joseph Pecoraro
Comment 3 2015-08-18 16:18:25 PDT
Created attachment 259310 [details] [IMAGE] After
Joseph Pecoraro
Comment 4 2015-08-18 16:19:09 PDT
Created attachment 259311 [details] [PATCH] Proposed Fix Note, no change for Retina (2x) devices, since they can do the half pixel checkered background necessary for 11x11 box.
Timothy Hatcher
Comment 5 2015-08-18 16:48:45 PDT
Comment on attachment 259311 [details] [PATCH] Proposed Fix The cubic-bezier might need tweaked too. It matches the size of this. Why not 10px for all devices?
Joseph Pecoraro
Comment 6 2015-08-18 16:51:32 PDT
(In reply to comment #5) > Comment on attachment 259311 [details] > [PATCH] Proposed Fix > > The cubic-bezier might need tweaked too. It matches the size of this. Why > not 10px for all devices? 10px is kinda small, 11px is great, 12px is too large compared to the text. So I'm preferring 11px (which is actually measured as 1em in the default case) for Retina.
Joseph Pecoraro
Comment 7 2015-08-18 17:02:52 PDT
Created attachment 259324 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 8 2015-08-18 17:57:05 PDT
Comment on attachment 259324 [details] [PATCH] Proposed Fix Clearing flags on attachment: 259324 Committed r188614: <http://trac.webkit.org/changeset/188614>
Note You need to log in before you can comment on or make changes to this bug.