Bug 148147

Summary: Web Inspector: Add proper formatting for editing styles in the Visual Panel
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Patch
none
Patch none

Description Devin Rousso 2015-08-18 15:46:09 PDT 
Currently, when any style changes in the Visual panel are saved to a resource (such as in the resources page) the formatting for those new styles is not consistent with the rest of the resource.  This needs to be changed to match the rest of the resource.
Comment 1 Radar WebKit Bug Importer 2015-08-18 15:46:53 PDT 
<rdar://problem/22333968>
Comment 2 Devin Rousso 2015-08-18 16:16:17 PDT 
Created attachment 259308 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-18 17:11:45 PDT 
Comment on attachment 259308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259308&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178
> +    _generateFormattedTextForNewProperty(styleText, propertyValue) {

No way to sure this with the other version below?
Comment 4 Devin Rousso 2015-08-18 17:16:08 PDT 
Comment on attachment 259308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259308&action=review

>> Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178
>> +    _generateFormattedTextForNewProperty(styleText, propertyValue) {
> 
> No way to sure this with the other version below?

Would making _generateFormattedTextForNewProperty a static function inside VisualStylePropertyEditor work?
Comment 5 Timothy Hatcher 2015-08-18 17:17:02 PDT 
If it was not prefixed with an underscore, sure.
Comment 6 Devin Rousso 2015-08-18 17:21:30 PDT 
Created attachment 259326 [details]
Patch
Comment 7 WebKit Commit Bot 2015-08-18 21:56:38 PDT 
Comment on attachment 259326 [details]
Patch

Clearing flags on attachment: 259326

Committed r188630: <http://trac.webkit.org/changeset/188630>
Comment 8 WebKit Commit Bot 2015-08-18 21:56:43 PDT 
All reviewed patches have been landed.  Closing bug.