Bug 148147

Summary: Web Inspector: Add proper formatting for editing styles in the Visual Panel
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2015-08-18 15:46:09 PDT
Currently, when any style changes in the Visual panel are saved to a resource (such as in the resources page) the formatting for those new styles is not consistent with the rest of the resource. This needs to be changed to match the rest of the resource.
Attachments
Patch (7.86 KB, patch)
2015-08-18 16:16 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, patch)
2015-08-18 17:21 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-18 15:46:53 PDT
<rdar://problem/22333968>
Devin Rousso
Comment 2 2015-08-18 16:16:17 PDT
Created attachment 259308 [details] Patch
Timothy Hatcher
Comment 3 2015-08-18 17:11:45 PDT
Comment on attachment 259308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259308&action=review > Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178 > + _generateFormattedTextForNewProperty(styleText, propertyValue) { No way to sure this with the other version below?
Devin Rousso
Comment 4 2015-08-18 17:16:08 PDT
Comment on attachment 259308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259308&action=review >> Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyCombiner.js:178 >> + _generateFormattedTextForNewProperty(styleText, propertyValue) { > > No way to sure this with the other version below? Would making _generateFormattedTextForNewProperty a static function inside VisualStylePropertyEditor work?
Timothy Hatcher
Comment 5 2015-08-18 17:17:02 PDT
If it was not prefixed with an underscore, sure.
Devin Rousso
Comment 6 2015-08-18 17:21:30 PDT
Created attachment 259326 [details] Patch
WebKit Commit Bot
Comment 7 2015-08-18 21:56:38 PDT
Comment on attachment 259326 [details] Patch Clearing flags on attachment: 259326 Committed r188630: <http://trac.webkit.org/changeset/188630>
WebKit Commit Bot
Comment 8 2015-08-18 21:56:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.