Bug 148146

Summary:

Search input results and clear icons are misaligned when padding is added

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	zalan: review+, buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none

Description Wenson Hsieh 2015-08-18 15:38:12 PDT

Open an HTML file with <input style="-webkit-appearance: textfield; padding: 10px;" value=test type=search results=5>. Observe that the magnifying glass (for results) and the cancel button are both clipped by the padding.

Comment 1 Wenson Hsieh 2015-08-18 15:38:52 PDT

<rdar://problem/22310951>

Comment 2 Wenson Hsieh 2015-08-18 16:27:09 PDT

Created attachment 259312 [details]
Patch

Comment 3 Wenson Hsieh 2015-08-18 16:31:24 PDT

Created attachment 259314 [details]
Patch

Comment 4 Build Bot 2015-08-18 16:48:55 PDT

Comment on attachment 259314 [details]
Patch

Attachment 259314 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/73346

New failing tests:
platform/mac/fast/forms/search/search-padding-cancel-results-buttons.html

Comment 5 Build Bot 2015-08-18 16:48:58 PDT

Created attachment 259321 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 6 Build Bot 2015-08-18 17:00:51 PDT

Comment on attachment 259314 [details]
Patch

Attachment 259314 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/73402

New failing tests:
platform/mac/fast/forms/search/search-padding-cancel-results-buttons.html

Comment 7 Build Bot 2015-08-18 17:00:54 PDT

Created attachment 259323 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 8 Wenson Hsieh 2015-08-18 17:23:55 PDT

Committed r188611: <http://trac.webkit.org/changeset/188611>