Bug 148143

Summary: Web Inspector: Modernize CSSStyleManager
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix bburg: review+

Joseph Pecoraro
Reported 2015-08-18 14:32:10 PDT
* SUMMARY Modernize CSSStyleManager. - Eliminate `delete` - Use Map instead of Object for a Map.
Attachments
[PATCH] Proposed Fix (6.65 KB, patch)
2015-08-18 14:34 PDT, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-08-18 14:34:48 PDT
Created attachment 259298 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 2 2015-08-18 15:01:08 PDT
Comment on attachment 259298 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=259298&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:-227 > - function syleSheetsFetched() Ouch! > Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:233 > var key = this._frameURLMapKey(frame, url); Can we move this above the callback and make it `let`? > Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:236 > + var styleSheet = this._styleSheetFrameURLMap.get(key) || this._styleSheetFrameURLMap.get(url) || null; let? > Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:347 > + this._ignoreResourceContentDidChangeEventForResource = null; Why null?
Joseph Pecoraro
Comment 3 2015-08-18 15:08:36 PDT
> > Source/WebInspectorUI/UserInterface/Controllers/CSSStyleManager.js:347 > > + this._ignoreResourceContentDidChangeEventForResource = null; > > Why null? I find `null` clearer here. It better signifies our intent for that property, "an object type goes here", better than undefined.
Joseph Pecoraro
Comment 4 2015-08-18 15:12:19 PDT
http://trac.webkit.org/changeset/188601
Note You need to log in before you can comment on or make changes to this bug.