Bug 148126

Summary: [EFL] Web Inspector: make to use StringBuilder in inspectorBaseURL
Product: WebKit Reporter: Jincheol Jo <jincheol.jo>
Component: WebKit EFLAssignee: Jincheol Jo <jincheol.jo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, hyungwook.lee, lucas.de.marchi
Priority: P2    
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jincheol Jo
Reported 2015-08-18 04:40:32 PDT
It returns chararacters array in WebInspectorProxy::inspectorBaseURL. So I made to use StringBuilder like the others of WebInspectorProxy.
Attachments
Patch (1.37 KB, patch)
2015-08-18 04:48 PDT, Jincheol Jo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jincheol Jo
Comment 1 2015-08-18 04:48:41 PDT
Created attachment 259262 [details] Patch
Gyuyoung Kim
Comment 2 2015-08-18 06:17:00 PDT
Comment on attachment 259262 [details] Patch There is no big benefit when using StringBuilder in this case though, it looks this patch is to be aligned with other similar EFL inspector functions.
WebKit Commit Bot
Comment 3 2015-08-18 21:23:24 PDT
Comment on attachment 259262 [details] Patch Clearing flags on attachment: 259262 Committed r188625: <http://trac.webkit.org/changeset/188625>
WebKit Commit Bot
Comment 4 2015-08-18 21:23:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.