Bug 148124

Summary:

Implement DragEvent and move MouseEvent.dataTransfer to DragEvent.

Product:

WebKit

Reporter:

Jincheol Jo <jincheol.jo>

Component:

DOM

Assignee:

Jincheol Jo <jincheol.jo>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, sam, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jincheol Jo 2015-08-18 00:21:38 PDT

I would like to implement DragEvent and move MouseEvent.dataTransfer to DragEvent.

Such is the spec:
https://html.spec.whatwg.org/multipage/interaction.html#dragevent

Gecko and Chrome already has the DragEvent interface and has the dataTransfer attribute only on that interface.
I added this in chromium as follows
http://src.chromium.org/viewvc/blink?view=revision&revision=200649

The change seems fairly low risk.

Comment 1 Jincheol Jo 2015-08-29 20:02:53 PDT

Created attachment 260231 [details]
Patch

Comment 2 Jincheol Jo 2015-08-29 20:03:30 PDT

Do not review. I am working on this.

Comment 3 WebKit Commit Bot 2015-08-29 20:04:19 PDT

Attachment 260231 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MouseEvent.cpp:115:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:116:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.cpp:274:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.h:63:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.h:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/MouseEvent.h:71:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/MouseEvent.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DOMAllInOne.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/dom/DragEvent.cpp:73:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/DragEvent.cpp:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DragEvent.cpp:68:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DragEvent.cpp:70:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DragEvent.cpp:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DragEvent.cpp:72:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/DragEvent.cpp:79:  Wrong number of spaces before statement. (expected: 27)  [whitespace/indent] [4]
ERROR: Source/WebCore/dom/DragEvent.cpp:74:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 16 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Sam Weinig 2015-08-30 10:19:51 PDT

Comment on attachment 260231 [details]
Patch

Unsetting the review flag as the author is not ready for review.