Bug 148123

Summary:

Web Inspector: Command-Enter should commit console command without erasing the prompt

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Animated GIF] With the patch applied	none
Patch	none

Description Nikita Vasilyev 2015-08-17 23:56:04 PDT

Created attachment 259255 [details]
[Animated GIF] With the patch applied

See the attached GIF.

Comment 1 Radar WebKit Bug Importer 2015-08-17 23:56:42 PDT

<rdar://problem/22321205>

Comment 2 Nikita Vasilyev 2015-08-18 00:00:55 PDT

Created attachment 259256 [details]
Patch

Comment 3 WebKit Commit Bot 2015-08-18 07:46:48 PDT

Comment on attachment 259256 [details]
Patch

Clearing flags on attachment: 259256

Committed r188581: <http://trac.webkit.org/changeset/188581>

Comment 4 WebKit Commit Bot 2015-08-18 07:46:51 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Joseph Pecoraro 2015-08-18 13:12:10 PDT

I use option+enter all the time to add a newline. Does this mean I have to use shift+enter now?

Comment 6 Timothy Hatcher 2015-08-18 17:08:52 PDT

I had forgotten about that. That is a typical way to get a line break in places that intercept Enter. Maybe Command-Enter for this?