Bug 148119

Summary: [Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegibility
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, glenn, jonlee, kondapallykalyan, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Myles C. Maxfield
Reported 2015-08-17 20:53:09 PDT
[Cocoa] Honor the 'trak' table by opting in via text-rendering: optimizeLegibility
Attachments
Patch (24.05 KB, patch)
2015-08-17 20:59 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (27.03 KB, patch)
2015-08-17 21:27 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (28.76 KB, patch)
2015-08-17 21:40 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (29.77 KB, patch)
2015-08-17 21:44 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (29.72 KB, patch)
2015-08-17 21:50 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (30.13 KB, patch)
2015-08-17 22:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (30.32 KB, patch)
2015-08-18 00:10 PDT, Myles C. Maxfield 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-08-17 20:59:57 PDT
Created attachment 259234 [details] Patch
Myles C. Maxfield
Comment 2 2015-08-17 21:00:35 PDT
<rdar://problem/22291561>
Myles C. Maxfield
Comment 3 2015-08-17 21:27:10 PDT
Created attachment 259238 [details] Patch
Myles C. Maxfield
Comment 4 2015-08-17 21:40:52 PDT
Created attachment 259241 [details] Patch
Myles C. Maxfield
Comment 5 2015-08-17 21:44:58 PDT
Created attachment 259242 [details] Patch
Myles C. Maxfield
Comment 6 2015-08-17 21:50:07 PDT
Created attachment 259244 [details] Patch
Myles C. Maxfield
Comment 7 2015-08-17 22:54:10 PDT
Created attachment 259251 [details] Patch
Myles C. Maxfield
Comment 8 2015-08-18 00:10:14 PDT
Created attachment 259257 [details] Patch
Tim Horton
Comment 9 2015-08-18 10:05:05 PDT
Comment on attachment 259257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259257&action=review > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:154 > + RetainPtr<CFDictionaryRef> dictionary; "dictionary"? maybe a better name here. "attributes"? > Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp:158 > + CFTypeRef keys[] = { kCTFontFeatureSettingsAttribute, kCTFontOpticalSizeAttribute }; I assume the reason for all the duplication here (instead of building up the dictionary) is performance, or something? Is this hot code? You could definitely make this more readable/less full of duplicated code.
Myles C. Maxfield
Comment 10 2015-08-18 12:19:58 PDT
Committed r188591: <http://trac.webkit.org/changeset/188591>
Myles C. Maxfield
Comment 11 2015-08-18 14:45:38 PDT
Committed r188597: <http://trac.webkit.org/changeset/188597>
Myles C. Maxfield
Comment 12 2015-08-20 20:20:28 PDT
Also http://trac.webkit.org/changeset/188743
Myles C. Maxfield
Comment 13 2015-12-07 16:05:29 PST
Removing Mavericks-specific lines from platform/mac/TestExpecations due to no longer supporting Mavericks.
Myles C. Maxfield
Comment 14 2015-12-07 16:10:48 PST
Committed r193663: <http://trac.webkit.org/changeset/193663>
Note You need to log in before you can comment on or make changes to this bug.