| Summary: | Web Inspector: Consider showing style summary on collapsed visual sidebar sections | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 147563 | ||||||||||
| Attachments: |
|
||||||||||
I like this idea, but I'm not sure how it would interface with the modified section indicators (the little blue dot on the left and trash can on the right). I do, however, have two issues: 1. For some of the comma separated properties, displaying them could be tough if there are multiple values (box-shadows, transitions, etc). 2. The "Display" section, as an example, has a bunch of unrelated properties under the same group. For this section (and ones of a similar format), how would we distinguish between "display" and "visibility" and "opacity" without explicitly stating that each value belongs to "display"/"visibility"/"opacity"? Could we maybe do this as a tooltip (it would have multiple lines in situations 1 and 2)? Valid questions and dilemmas. Maybe what I am more expecting us to see a dot more often. Right now it is only there for when the user makes a change in that section. But really I am curious what sections have author properties active. The auto expanding helps here, but I've manually expanded sections I plan to use or look at often. I'd like to know at a glance if that section has non-computed values. Created attachment 259313 [details]
Patch
Comment on attachment 259313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259313&action=review > Source/WebInspectorUI/ChangeLog:22 > + Web Inspector: font-family list is backwards in visual sidebar Oops. Comment on attachment 259313 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259313&action=review > Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:159 > + this._commaSeparatedKeywords.insertChild(valueElement, index + !this._insertNewItemsBeforeSelected); Remove from this patch. (In reply to comment #6) > > Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:159 > > + this._commaSeparatedKeywords.insertChild(valueElement, index + !this._insertNewItemsBeforeSelected); > > Remove from this patch. Whoops. That was an accident. Created attachment 259327 [details]
Patch
Removed accidental changeling entry.
Comment on attachment 259327 [details] Patch Clearing flags on attachment: 259327 Committed r188617: <http://trac.webkit.org/changeset/188617> All reviewed patches have been landed. Closing bug. |
Created attachment 259203 [details] Screenshot The sections of the visual sidebar might be more useful when collapsed if they had a summary best to the title. Like "➤ Shadow — None", "➤ Font — sans-serif 12px", etc. We could show these summaries in a lighter grey to deemphasize them a bit.