Summary: | Web Inspector: Small Caps variant checkbox should be to the left of the Small Caps label | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 147563 | ||||||||||
Attachments: |
|
Created attachment 259222 [details]
Patch
Comment on attachment 259222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=259222&action=review > Source/WebInspectorUI/UserInterface/Views/VisualStyleKeywordCheckbox.css:37 > + margin-left: 0.5px; Let's use whole pixels. (In reply to comment #3) > Comment on attachment 259222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=259222&action=review > > > Source/WebInspectorUI/UserInterface/Views/VisualStyleKeywordCheckbox.css:37 > > + margin-left: 0.5px; > > Let's use whole pixels. I am using a half-pixel so that the checkbox aligns exactly with the other editor elements near it. It works on retina devices, but I am going to do a comprehensive review on a non-retina screen later today/tomorrow and make any necessary changes there. With that in mind, is it OK to commit this for the retina devices? Created attachment 259348 [details]
Patch
I decided to remove the margin-left altogether. It looks much nicer without it.
Comment on attachment 259348 [details] Patch Clearing flags on attachment: 259348 Committed r188626: <http://trac.webkit.org/changeset/188626> All reviewed patches have been landed. Closing bug. |
Created attachment 259201 [details] Screenshot See screenshot. The checkbox should be first.