Bug 148101

Summary: Web Inspector: font-family list is backwards in visual sidebar
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, hi, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 147563    
Attachments:
Description Flags
Screenshot
none
Patch
none
Patch none

Description Timothy Hatcher 2015-08-17 16:36:21 PDT
Created attachment 259200 [details]
Screenshot

From apple.com:

 font-family:"Myriad Set Pro","Lucida Grande","Helvetica Neue","Helvetica","Arial","Verdana","sans-serif";

But the visual sidebar shows this list in reverse, with sans-serif at the top.
Comment 1 Radar WebKit Bug Importer 2015-08-17 16:36:50 PDT
<rdar://problem/22316962>
Comment 2 Devin Rousso 2015-08-17 19:22:34 PDT
Created attachment 259225 [details]
Patch
Comment 3 Timothy Hatcher 2015-08-17 20:20:10 PDT
Comment on attachment 259225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259225&action=review

> Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:157
>          let indexIsSet = !isNaN(index);

Remove or use.
Comment 4 Devin Rousso 2015-08-17 20:27:20 PDT
Created attachment 259228 [details]
Patch
Comment 5 WebKit Commit Bot 2015-08-17 21:14:03 PDT
Comment on attachment 259228 [details]
Patch

Clearing flags on attachment: 259228

Committed r188573: <http://trac.webkit.org/changeset/188573>
Comment 6 WebKit Commit Bot 2015-08-17 21:14:08 PDT
All reviewed patches have been landed.  Closing bug.